From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gaudenz Steinlin <gaudenz@soziologie.ch>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook
Date: Fri, 06 Mar 2009 20:57:20 +1100 [thread overview]
Message-ID: <1236333440.7260.136.camel@pasglop> (raw)
In-Reply-To: <20090306090906.GA5183@soziologie.ch>
> So you are able to resume with my minimal config + CPU_FREQ? This would
> be really strange if it is really the exact same model.
Yes, it appears to be :-)
> To verify if we really have the same model I included some data below. I
> also included the gcc and binutils versions.
>
> Please tell me if you have any further ideas on what to test.
In the commmit your revert, I added a function that "tests" if the chip
appears to need to be POSTed: radeon_check_power_loss(). Try commenting
out the content and make it always return 1.
Another thing you can try in radeonfb_pci_resume():
if (pdev->dev.power.power_state.event == PM_EVENT_SUSPEND) {
+ pci_restore_state(pdev);
+ pci_enable_device(pdev);
+ pci_set_master(pdev);
/* Wakeup chip */
And if that helps, then try to find out which of these 3 things helped.
Cheers,
Ben.
next prev parent reply other threads:[~2009-03-06 9:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 8:38 commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook Gaudenz Steinlin
2009-03-04 23:22 ` Benjamin Herrenschmidt
2009-03-05 10:25 ` Gaudenz Steinlin
2009-03-05 2:25 ` Benjamin Herrenschmidt
2009-03-05 12:59 ` Gaudenz Steinlin
2009-03-06 5:50 ` Benjamin Herrenschmidt
2009-03-06 9:09 ` Gaudenz Steinlin
2009-03-06 9:57 ` Benjamin Herrenschmidt [this message]
2009-03-06 11:41 ` Gaudenz Steinlin
2009-03-06 21:26 ` Benjamin Herrenschmidt
2009-03-09 22:37 ` Benjamin Herrenschmidt
2009-03-10 9:32 ` Rafael J. Wysocki
2009-03-10 15:01 ` Gaudenz Steinlin
2009-03-10 20:58 ` Benjamin Herrenschmidt
2009-03-10 21:27 ` Gaudenz Steinlin
2009-03-10 21:30 ` Gaudenz Steinlin
2009-03-10 22:07 ` Benjamin Herrenschmidt
2009-03-10 23:04 ` Rafael J. Wysocki
2009-03-11 0:34 ` Benjamin Herrenschmidt
2009-03-09 22:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236333440.7260.136.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=gaudenz@soziologie.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.