All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gaudenz Steinlin <gaudenz@soziologie.ch>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook
Date: Sat, 07 Mar 2009 08:26:07 +1100	[thread overview]
Message-ID: <1236374767.7260.152.camel@pasglop> (raw)
In-Reply-To: <20090306114149.GA5371@soziologie.ch>

On Fri, 2009-03-06 at 12:41 +0100, Gaudenz Steinlin wrote:
> 
> Adding this fixes the bug. Apparently the PCI core does not fully
> restore the state. Before your suggestions I also tried to find out
> which part of your commit breaks resume and I found out that if I
> reinsert the parts to save and restore the pci configuration the bug
> is
> fixed. It seems that somehow the PCI coniguration is not fully
> restored [1].  

Ok, well, I though it would be due to some upstream changes but it's
possible that I either mis-read those changes or they got themselves
changed in some subtle way after I did that commit :-)

I still find it fascinating that it doesn't break for me here since it
is effectively the same machine model !

I'll do a patch fixing that but it will have to wait for monday.

Cheers,
Ben.


  reply	other threads:[~2009-03-06 21:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  8:38 commit "radeonfb: Fix resume from D3Cold on some platforms" breaks resume from RAM on PowerBook Gaudenz Steinlin
2009-03-04 23:22 ` Benjamin Herrenschmidt
2009-03-05 10:25   ` Gaudenz Steinlin
2009-03-05  2:25 ` Benjamin Herrenschmidt
2009-03-05 12:59   ` Gaudenz Steinlin
2009-03-06  5:50     ` Benjamin Herrenschmidt
2009-03-06  9:09       ` Gaudenz Steinlin
2009-03-06  9:57         ` Benjamin Herrenschmidt
2009-03-06 11:41           ` Gaudenz Steinlin
2009-03-06 21:26             ` Benjamin Herrenschmidt [this message]
2009-03-09 22:37             ` Benjamin Herrenschmidt
2009-03-10  9:32               ` Rafael J. Wysocki
2009-03-10 15:01                 ` Gaudenz Steinlin
2009-03-10 20:58                   ` Benjamin Herrenschmidt
2009-03-10 21:27                     ` Gaudenz Steinlin
2009-03-10 21:30               ` Gaudenz Steinlin
2009-03-10 22:07                 ` Benjamin Herrenschmidt
2009-03-10 23:04                   ` Rafael J. Wysocki
2009-03-11  0:34                     ` Benjamin Herrenschmidt
2009-03-09 22:49             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236374767.7260.152.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=gaudenz@soziologie.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.