From: Manoel Rebelo Abranches <mrabran@linux.vnet.ibm.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH]: grub: Fix type of 'actual' size arguments to ieee1275 interfaces.
Date: Thu, 09 Apr 2009 20:00:43 -0300 [thread overview]
Message-ID: <1239318043.3478.11.camel@localhost> (raw)
In-Reply-To: <20090409.140532.24918882.davem@davemloft.net>
This patch is ok. it shouldn't be int.
On Thu, 2009-04-09 at 14:05 -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 07 Apr 2009 17:03:27 -0700 (PDT)
>
> > The 'actual' argument to various ieee1275 functions is of type
> > "grub_ssize_t" but several spots were erroneously using "int".
> >
> > This happens to work on powerpc but does not on sparc64.
> >
> > 2009-04-07 David S. Miller <davem@davemloft.net>
> >
> > * kern/ieee1275/init.c (grub_machine_init): Make 'actual' grub_ssize_t.
> > * kern/ieee1275/openfw.c (grub_children_iterate): Likewise.
> > (grub_devalias_iterate): Likewise.
>
> Ping? Review appreciated, thanks!
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Best Regards,
Manoel Rebelo Abranches
IBM Linux Technology Center Brazil
next prev parent reply other threads:[~2009-04-09 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 0:03 [PATCH]: grub: Fix type of 'actual' size arguments to ieee1275 interfaces David Miller
2009-04-09 21:05 ` David Miller
2009-04-09 23:00 ` Manoel Rebelo Abranches [this message]
2009-04-11 3:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239318043.3478.11.camel@localhost \
--to=mrabran@linux.vnet.ibm.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.