[PATCH]: grub: Fix type of 'actual' size arguments to ieee1275 interfaces.

* [PATCH]: grub: Fix type of 'actual' size arguments to ieee1275 interfaces.
@ 2009-04-08  0:03 David Miller
  2009-04-09 21:05 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-04-08  0:03 UTC (permalink / raw)
  To: grub-devel


The 'actual' argument to various ieee1275 functions is of type
"grub_ssize_t" but several spots were erroneously using "int".

This happens to work on powerpc but does not on sparc64.

2009-04-07  David S. Miller  <davem@davemloft.net>

	* kern/ieee1275/init.c (grub_machine_init): Make 'actual' grub_ssize_t.
	* kern/ieee1275/openfw.c (grub_children_iterate): Likewise.
	(grub_devalias_iterate): Likewise.
---
 kern/ieee1275/init.c   |    2 +-
 kern/ieee1275/openfw.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kern/ieee1275/init.c b/kern/ieee1275/init.c
index d345ba2..27783cc 100644
--- a/kern/ieee1275/init.c
+++ b/kern/ieee1275/init.c
@@ -213,7 +213,7 @@ void
 grub_machine_init (void)
 {
   char args[256];
-  int actual;
+  grub_ssize_t actual;
 
   grub_ieee1275_init ();
 
diff --git a/kern/ieee1275/openfw.c b/kern/ieee1275/openfw.c
index 4c8cc6a..d70c3ba 100644
--- a/kern/ieee1275/openfw.c
+++ b/kern/ieee1275/openfw.c
@@ -53,7 +53,7 @@ grub_children_iterate (char *devpath,
       char childname[64];
       char fullname[64];
       struct grub_ieee1275_devalias alias;
-      int actual;
+      grub_ssize_t actual;
 
       if (grub_ieee1275_get_property (child, "device_type", &childtype,
 				      sizeof childtype, &actual))
@@ -86,7 +86,7 @@ grub_devalias_iterate (int (*hook) (struct grub_ieee1275_devalias *alias))
 {
   grub_ieee1275_phandle_t aliases;
   char aliasname[32];
-  int actual;
+  grub_ssize_t actual;
   struct grub_ieee1275_devalias alias;
 
   if (grub_ieee1275_finddevice ("/aliases", &aliases))
-- 
1.6.2.2




^ permalink raw reply related	[flat|nested] 4+ messages in thread