From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 4/5] arm64: dts: sunxi: add SCPI driven clocks and nodes for A64 MMC
Date: Wed, 10 Aug 2016 23:01:48 +0800 [thread overview]
Message-ID: <1241311470841308@web22g.yandex.ru> (raw)
In-Reply-To: <20160809115303.17032-5-andre.przywara@arm.com>
09.08.2016, 19:58, "Andre Przywara" <andre.przywara@arm.com>:
> ?The MMC controllers in the Allwinner A64 SoC are somewhat compatible
> ?with the versions used in other Allwinner SoCs.
> ?Tell Linux about the three MMC clocks that the firmware implements and
> ?add nodes to represent the MMC controllers.
> ?The actual hardware is capable of new transfer modes, which the driver
> ?does not fully support yet, also the clock part has changed, but it
> ?works like this at least for SD card accesses.
>
> ?Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ?---
> ??arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 61 +++++++++++++++++++++++++++
> ??1 file changed, 61 insertions(+)
>
> ?diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> ?index 9fc540e..0f6044b 100644
> ?--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> ?+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> ?@@ -157,6 +157,19 @@
> ??????????????????compatible = "arm,scpi";
> ??????????????????mboxes = <&mailbox 0>;
> ??????????????????shmem = <&cpu_scp_mem>;
> ?+
> ?+ clocks {
> ?+ compatible = "arm,scpi-clocks";
> ?+
> ?+ scpi_clk: scpi_clocks {
> ?+ compatible = "arm,scpi-variable-clocks";
> ?+ #clock-cells = <1>;
> ?+ clock-indices = <0>, <1>,
I found a problem of the "standardize" process.
There cannot be an authority to keep the clock ID standardized, in both
> ?+ <2>;
> ?+ clock-output-names = "mmc0_clk", "mmc1_clk",
> ?+ "mmc2_clk";
> ?+ };
> ?+ };
> ??????????};
>
> ??????????soc {
> ?@@ -165,6 +178,54 @@
> ??????????????????#size-cells = <1>;
> ??????????????????ranges;
>
> ?+ mmc0: mmc at 1c0f000 {
> ?+ compatible = "allwinner,sun50i-a64-mmc",
> ?+ "allwinner,sun5i-a13-mmc";
> ?+ reg = <0x01c0f000 0x1000>;
> ?+ clocks = <&bus_gates 8>, <&scpi_clk 0>,
> ?+ <&scpi_clk 0>, <&scpi_clk 0>;
> ?+ clock-names = "ahb", "mmc",
> ?+ "output", "sample";
> ?+ resets = <&ahb_rst 8>;
> ?+ reset-names = "ahb";
> ?+ interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> ?+ status = "disabled";
> ?+ #address-cells = <1>;
> ?+ #size-cells = <0>;
> ?+ };
> ?+
> ?+ mmc1: mmc at 1c10000 {
> ?+ compatible = "allwinner,sun50i-a64-mmc",
> ?+ "allwinner,sun5i-a13-mmc";
> ?+ reg = <0x01c10000 0x1000>;
> ?+ clocks = <&bus_gates 9>, <&scpi_clk 1>,
> ?+ <&scpi_clk 1>, <&scpi_clk 1>;
> ?+ clock-names = "ahb", "mmc",
> ?+ "output", "sample";
> ?+ resets = <&ahb_rst 9>;
> ?+ reset-names = "ahb";
> ?+ interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> ?+ status = "disabled";
> ?+ #address-cells = <1>;
> ?+ #size-cells = <0>;
> ?+ };
> ?+
> ?+ mmc2: mmc at 1c11000 {
> ?+ compatible = "allwinner,sun50i-a64-mmc",
> ?+ "allwinner,sun5i-a13-mmc";
> ?+ reg = <0x01c11000 0x1000>;
> ?+ clocks = <&bus_gates 10>, <&scpi_clk 2>,
> ?+ <&scpi_clk 2>, <&scpi_clk 2>;
> ?+ clock-names = "ahb", "mmc",
> ?+ "output", "sample";
> ?+ resets = <&ahb_rst 10>;
> ?+ reset-names = "ahb";
> ?+ interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> ?+ status = "disabled";
> ?+ #address-cells = <1>;
> ?+ #size-cells = <0>;
> ?+ };
> ?+
> ??????????????????pio: pinctrl at 1c20800 {
> ??????????????????????????compatible = "allwinner,sun50i-a64-pinctrl";
> ??????????????????????????reg = <0x01c20800 0x400>;
> ?--
> ?2.9.0
>
> ?_______________________________________________
> ?linux-arm-kernel mailing list
> ?linux-arm-kernel at lists.infradead.org
> ?http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
To: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [RFC PATCH 4/5] arm64: dts: sunxi: add SCPI driven clocks and nodes for A64 MMC
Date: Wed, 10 Aug 2016 23:01:48 +0800 [thread overview]
Message-ID: <1241311470841308@web22g.yandex.ru> (raw)
In-Reply-To: <20160809115303.17032-5-andre.przywara-5wv7dgnIgG8@public.gmane.org>
09.08.2016, 19:58, "Andre Przywara" <andre.przywara-5wv7dgnIgG8@public.gmane.org>:
> The MMC controllers in the Allwinner A64 SoC are somewhat compatible
> with the versions used in other Allwinner SoCs.
> Tell Linux about the three MMC clocks that the firmware implements and
> add nodes to represent the MMC controllers.
> The actual hardware is capable of new transfer modes, which the driver
> does not fully support yet, also the clock part has changed, but it
> works like this at least for SD card accesses.
>
> Signed-off-by: Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 61 +++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 9fc540e..0f6044b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -157,6 +157,19 @@
> compatible = "arm,scpi";
> mboxes = <&mailbox 0>;
> shmem = <&cpu_scp_mem>;
> +
> + clocks {
> + compatible = "arm,scpi-clocks";
> +
> + scpi_clk: scpi_clocks {
> + compatible = "arm,scpi-variable-clocks";
> + #clock-cells = <1>;
> + clock-indices = <0>, <1>,
I found a problem of the "standardize" process.
There cannot be an authority to keep the clock ID standardized, in both
> + <2>;
> + clock-output-names = "mmc0_clk", "mmc1_clk",
> + "mmc2_clk";
> + };
> + };
> };
>
> soc {
> @@ -165,6 +178,54 @@
> #size-cells = <1>;
> ranges;
>
> + mmc0: mmc@1c0f000 {
> + compatible = "allwinner,sun50i-a64-mmc",
> + "allwinner,sun5i-a13-mmc";
> + reg = <0x01c0f000 0x1000>;
> + clocks = <&bus_gates 8>, <&scpi_clk 0>,
> + <&scpi_clk 0>, <&scpi_clk 0>;
> + clock-names = "ahb", "mmc",
> + "output", "sample";
> + resets = <&ahb_rst 8>;
> + reset-names = "ahb";
> + interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + mmc1: mmc@1c10000 {
> + compatible = "allwinner,sun50i-a64-mmc",
> + "allwinner,sun5i-a13-mmc";
> + reg = <0x01c10000 0x1000>;
> + clocks = <&bus_gates 9>, <&scpi_clk 1>,
> + <&scpi_clk 1>, <&scpi_clk 1>;
> + clock-names = "ahb", "mmc",
> + "output", "sample";
> + resets = <&ahb_rst 9>;
> + reset-names = "ahb";
> + interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + mmc2: mmc@1c11000 {
> + compatible = "allwinner,sun50i-a64-mmc",
> + "allwinner,sun5i-a13-mmc";
> + reg = <0x01c11000 0x1000>;
> + clocks = <&bus_gates 10>, <&scpi_clk 2>,
> + <&scpi_clk 2>, <&scpi_clk 2>;
> + clock-names = "ahb", "mmc",
> + "output", "sample";
> + resets = <&ahb_rst 10>;
> + reset-names = "ahb";
> + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> pio: pinctrl@1c20800 {
> compatible = "allwinner,sun50i-a64-pinctrl";
> reg = <0x01c20800 0x400>;
> --
> 2.9.0
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-08-10 15:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:52 [RFC PATCH 0/5] Allwinner MMC firmware clocks implementation Andre Przywara
2016-08-09 11:52 ` Andre Przywara
2016-08-09 11:52 ` [RFC PATCH 1/5] mailbox: introduce ARM SMC based mailbox Andre Przywara
2016-08-09 11:52 ` Andre Przywara
2016-08-10 8:58 ` [linux-sunxi] " LABBE Corentin
2016-08-10 8:58 ` LABBE Corentin
2016-08-09 11:53 ` [RFC PATCH 2/5] DT: mailbox: add binding doc for the ARM SMC mailbox Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-10 21:57 ` Rob Herring
2016-08-10 21:57 ` Rob Herring
2016-08-10 21:57 ` Rob Herring
2016-08-09 11:53 ` [RFC PATCH 3/5] arm64: dts: sunxi: add SCPI node to sun50i-a64.dtsi Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 11:53 ` [RFC PATCH 4/5] arm64: dts: sunxi: add SCPI driven clocks and nodes for A64 MMC Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-10 15:01 ` Icenowy Zheng [this message]
2016-08-10 15:01 ` Icenowy Zheng
2016-08-10 23:19 ` André Przywara
2016-08-10 23:19 ` André Przywara
2016-08-10 23:19 ` André Przywara
2016-08-11 2:45 ` Icenowy Zheng
2016-08-11 2:45 ` Icenowy Zheng
2016-08-09 11:53 ` [RFC PATCH 5/5] arm64: dts: sunxi: add MMC nodes to Pine64 and BPi-M64 .dts Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 11:53 ` Andre Przywara
2016-08-09 13:04 ` [RFC PATCH 0/5] Allwinner MMC firmware clocks implementation Stefan Monnier
2016-08-10 15:10 ` Icenowy Zheng
2016-08-10 23:18 ` André Przywara
2016-08-10 23:18 ` André Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241311470841308@web22g.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.