All of lore.kernel.org
 help / color / mirror / Atom feed
From: clabbe.montjoie@gmail.com (LABBE Corentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [RFC PATCH 1/5] mailbox: introduce ARM SMC based mailbox
Date: Wed, 10 Aug 2016 10:58:23 +0200	[thread overview]
Message-ID: <20160810085823.GA21702@Red> (raw)
In-Reply-To: <20160809115303.17032-2-andre.przywara@arm.com>

Hello

Just a minor comment below

> +static int smc_mbox_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct mbox_controller *mbox;
> +	int ret = 0;
> +	int i;
> +
> +	ret = of_property_count_elems_of_size(dev->of_node, "identifiers",
> +					      sizeof(u32));
> +	if (ret < 0)
> +		return ret;
> +
> +	mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
> +	if (mbox == NULL)
> +		return -ENOMEM;

checkpatch prefer !mbox

> +
> +	mbox->num_chans = ret;
> +	mbox->chans = devm_kmalloc_array(dev, mbox->num_chans,
> +					 sizeof(*mbox->chans),
> +					 GFP_KERNEL | __GFP_ZERO);

devm_kcalloc seems to do the same

Regards

LABBE Corentin

WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@googlegroups.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [linux-sunxi] [RFC PATCH 1/5] mailbox: introduce ARM SMC based mailbox
Date: Wed, 10 Aug 2016 10:58:23 +0200	[thread overview]
Message-ID: <20160810085823.GA21702@Red> (raw)
In-Reply-To: <20160809115303.17032-2-andre.przywara@arm.com>

Hello

Just a minor comment below

> +static int smc_mbox_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct mbox_controller *mbox;
> +	int ret = 0;
> +	int i;
> +
> +	ret = of_property_count_elems_of_size(dev->of_node, "identifiers",
> +					      sizeof(u32));
> +	if (ret < 0)
> +		return ret;
> +
> +	mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
> +	if (mbox == NULL)
> +		return -ENOMEM;

checkpatch prefer !mbox

> +
> +	mbox->num_chans = ret;
> +	mbox->chans = devm_kmalloc_array(dev, mbox->num_chans,
> +					 sizeof(*mbox->chans),
> +					 GFP_KERNEL | __GFP_ZERO);

devm_kcalloc seems to do the same

Regards

LABBE Corentin

  reply	other threads:[~2016-08-10  8:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 11:52 [RFC PATCH 0/5] Allwinner MMC firmware clocks implementation Andre Przywara
2016-08-09 11:52 ` Andre Przywara
2016-08-09 11:52 ` [RFC PATCH 1/5] mailbox: introduce ARM SMC based mailbox Andre Przywara
2016-08-09 11:52   ` Andre Przywara
2016-08-10  8:58   ` LABBE Corentin [this message]
2016-08-10  8:58     ` [linux-sunxi] " LABBE Corentin
2016-08-09 11:53 ` [RFC PATCH 2/5] DT: mailbox: add binding doc for the ARM SMC mailbox Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-10 21:57   ` Rob Herring
2016-08-10 21:57     ` Rob Herring
2016-08-10 21:57     ` Rob Herring
2016-08-09 11:53 ` [RFC PATCH 3/5] arm64: dts: sunxi: add SCPI node to sun50i-a64.dtsi Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 11:53 ` [RFC PATCH 4/5] arm64: dts: sunxi: add SCPI driven clocks and nodes for A64 MMC Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-10 15:01   ` Icenowy Zheng
2016-08-10 15:01     ` Icenowy Zheng
2016-08-10 23:19     ` André Przywara
2016-08-10 23:19       ` André Przywara
2016-08-10 23:19       ` André Przywara
2016-08-11  2:45       ` Icenowy Zheng
2016-08-11  2:45         ` Icenowy Zheng
2016-08-09 11:53 ` [RFC PATCH 5/5] arm64: dts: sunxi: add MMC nodes to Pine64 and BPi-M64 .dts Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 11:53   ` Andre Przywara
2016-08-09 13:04 ` [RFC PATCH 0/5] Allwinner MMC firmware clocks implementation Stefan Monnier
2016-08-10 15:10 ` Icenowy Zheng
2016-08-10 23:18   ` André Przywara
2016-08-10 23:18     ` André Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810085823.GA21702@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.