Re: New reflink(2) syscall

[Stephen Smalley <sds@tycho.nsa.gov>]

On Wed, 2009-05-06 at 08:15 +1000, James Morris wrote:
> On Tue, 5 May 2009, Joel Becker wrote:
> 
> > On Mon, May 04, 2009 at 12:59:39PM -0400, Stephen Smalley wrote:
> > > On Tue, 2009-05-05 at 01:35 +1000, James Morris wrote:
> > > > Agreed, perhaps something like:
> > > > 
> > > > int security_inode_reflink(struct dentry *dentry, struct inode *dir);
> > > 
> > > I'd pass the same arguments as vfs_reflink(), i.e. old_dentry, dir,
> > > new_dentry.
> > 
> > 	I'm about to insert this bit.  I agree with
> > security_inode_reflink(old_dentry, dir, new_dentry),
> 
> If the files and metadata are initially identical (except for inode #), 
> why do we need to see both the old and new dentry?

Fair enough - he can drop the new_dentry argument.  selinux_inode_link()
doesn't use the new_dentry argument to security_inode_link() either.

-- 
Stephen Smalley
National Security Agency