All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Rudolf Marek <r.marek@assembler.cz>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for
Date: Sun, 24 May 2009 12:31:44 +0000	[thread overview]
Message-ID: <1243167584.3036.14.camel@localhost.localdomain> (raw)
In-Reply-To: <4A182B61.5010503@assembler.cz>

On Sat, 2009-05-23 at 18:59 +0200, Rudolf Marek wrote:
> Hi,
> 
> Yes it works for most CPUs, but for unlucky users we might get complains from 
> them - and false alarms.
> 
> I'm talking about:
> 
> http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/41322.pdf
> 
> Errata #319
> 
> So far all CPUs have the issue.

From manual :

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
319 Inaccurate Temperature Measurement
Description
The internal thermal sensor used for CurTmp (F3xA4[31:21]), hardware thermal control (HTC),
software thermal control (STC) thermal zone, and the sideband temperature sensor interface (SB-TSI)
may report inconsistent values.
Potential Effect on System
HTC, STC thermal zone, and SB-TSI do not provide reliable thermal protection. This does not affect
THERMTRIP or the use of the STC-active state through StcPstateLimit or StcPstateEn
(F3x68[30:28, 5]).
Suggested Workaround
None. Systems should be designed with conventional thermal control and throttling methods or
utilize PROCHOT_L functionality based on temperature measurements from an analog thermal diode
(THERMDA/THERMDC).
Systems should not rely on the HTC features, STC thermal zone features, or use SB-TSI.
Software should not modify HtcTmpLmt (F3x64[22:16]) or enable any of the STC thermal zone
features by setting StcApcTmpLoEn, StcApcTmpHiEn, StcSbcTmpLoEn, or StcSpcTmpHiEn
(F3x68[3:0]).

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

It seems that this problem is for some K10 processors.
And K11 is OK, right ?

I think our patch is safe enough and we will fix the problem for some
K10 processors or in the worst case we will remove support for that
particular cpu.

Ingo: do you mind to applying this patch on -tip and lets see its
feedback and fix the problem.

Thanks
--
JSR



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Rudolf Marek <r.marek@assembler.cz>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H
Date: Sun, 24 May 2009 17:49:44 +0530	[thread overview]
Message-ID: <1243167584.3036.14.camel@localhost.localdomain> (raw)
In-Reply-To: <4A182B61.5010503@assembler.cz>

On Sat, 2009-05-23 at 18:59 +0200, Rudolf Marek wrote:
> Hi,
> 
> Yes it works for most CPUs, but for unlucky users we might get complains from 
> them - and false alarms.
> 
> I'm talking about:
> 
> http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/41322.pdf
> 
> Errata #319
> 
> So far all CPUs have the issue.

>From manual :

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
319 Inaccurate Temperature Measurement
Description
The internal thermal sensor used for CurTmp (F3xA4[31:21]), hardware thermal control (HTC),
software thermal control (STC) thermal zone, and the sideband temperature sensor interface (SB-TSI)
may report inconsistent values.
Potential Effect on System
HTC, STC thermal zone, and SB-TSI do not provide reliable thermal protection. This does not affect
THERMTRIP or the use of the STC-active state through StcPstateLimit or StcPstateEn
(F3x68[30:28, 5]).
Suggested Workaround
None. Systems should be designed with conventional thermal control and throttling methods or
utilize PROCHOT_L functionality based on temperature measurements from an analog thermal diode
(THERMDA/THERMDC).
Systems should not rely on the HTC features, STC thermal zone features, or use SB-TSI.
Software should not modify HtcTmpLmt (F3x64[22:16]) or enable any of the STC thermal zone
features by setting StcApcTmpLoEn, StcApcTmpHiEn, StcSbcTmpLoEn, or StcSpcTmpHiEn
(F3x68[3:0]).

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

It seems that this problem is for some K10 processors.
And K11 is OK, right ?

I think our patch is safe enough and we will fix the problem for some
K10 processors or in the worst case we will remove support for that
particular cpu.

Ingo: do you mind to applying this patch on -tip and lets see its
feedback and fix the problem.

Thanks
--
JSR



  reply	other threads:[~2009-05-24 12:31 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22  8:04 [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jaswinder Singh Rajput
2009-05-22  8:16 ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Rudolf Marek
2009-05-22  8:16   ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Rudolf Marek
2009-05-22  8:42   ` Jaswinder Singh Rajput
2009-05-22  8:54     ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-22  9:30     ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jaswinder Singh Rajput
2009-05-22  9:42       ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-23 16:59       ` Rudolf Marek
2009-05-23 16:59         ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Rudolf Marek
2009-05-24 12:19         ` Jaswinder Singh Rajput [this message]
2009-05-24 12:31           ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-26 12:10         ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jaswinder Singh Rajput
2009-05-26 12:22           ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-26 15:20           ` Rudolf Marek
2009-05-26 15:20             ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Rudolf Marek
2009-05-26 15:44             ` Jaswinder Singh Rajput
2009-05-26 15:56               ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-28 11:57               ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jaswinder Singh Rajput
2009-05-28 12:09                 ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-28 12:28                 ` Jean Delvare
2009-05-28 12:28                   ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jean Delvare
2009-05-28 14:13                   ` Jaswinder Singh Rajput
2009-05-28 14:25                     ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-05-28 14:49                     ` [lm-sensors] [stable] [PATCH-tip] x86: hwmon/k8temp.c Greg KH
2009-05-28 14:49                       ` [stable] [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Greg KH
2009-05-29  5:42                       ` Jaswinder Singh Rajput
2009-05-29  5:54                         ` [lm-sensors] [stable] [PATCH-tip] x86: hwmon/k8temp.c Add Jaswinder Singh Rajput
2009-05-29  6:05                         ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jean Delvare
2009-05-29  6:05                           ` [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jean Delvare
2009-06-06 10:36               ` Jaswinder Singh Rajput
2009-06-06 10:48                 ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput
2009-06-20  7:56               ` [HWMON] x86: hwmon/k8temp.c Add support for AMD 11H Jaswinder Singh Rajput
2009-06-20  8:08                 ` [lm-sensors] " Jaswinder Singh Rajput
2009-06-25 14:09                 ` Jaswinder Singh Rajput
2009-06-25 14:21                   ` [lm-sensors] " Jaswinder Singh Rajput
2009-07-19  5:03                   ` Jaswinder Singh Rajput
2009-07-19  5:15                     ` [lm-sensors] " Jaswinder Singh Rajput
2009-05-25 13:45       ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jean Delvare
2009-05-25 13:45         ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for AMD 10H and 11H Jean Delvare
2009-05-25 14:17         ` Jaswinder Singh Rajput
2009-05-25 14:29           ` [lm-sensors] [PATCH-tip] x86: hwmon/k8temp.c Add support for Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243167584.3036.14.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@elte.hu \
    --cc=r.marek@assembler.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.