From: Jouni Malinen <jouni.malinen@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 4/4] mac80211: Fix typos in "set default QoS values according to spec"
Date: Wed, 27 May 2009 08:12:52 +0300 [thread overview]
Message-ID: <1243401172.30310.4.camel@jm-desktop> (raw)
In-Reply-To: <1243400715-13561-4-git-send-email-x@jeffhansen.com>
On Tue, 2009-05-26 at 22:05 -0700, Jeff Hansen wrote:
> Some of the acwmin and acwmax values were backwards in the original patch,
> which cut TX performance (on my device at least) down from ~25-30Mbps to
> 2Mbps. Performance is back up after this commit.
Thanks for reporting these and verifying that this fixes the issue.
However, not all of these are typos.. In addition,
linux-wireless at vger.kernel.org should be cc'ed.
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> @@ -657,20 +657,20 @@ void ieee80211_set_wmm_default(struct ieee80211_sub_if_data *sdata)
>
> switch (queue) {
> case 3: /* AC_BK */
> - qparam.cw_max = aCWmin;
> - qparam.cw_min = aCWmax;
> + qparam.cw_max = aCWmax;
> + qparam.cw_min = aCWmin;
> qparam.txop = 0;
> qparam.aifs = 7;
> break;
> default: /* never happens but let's not leave undefined */
> case 2: /* AC_BE */
> - qparam.cw_max = aCWmin;
> - qparam.cw_min = aCWmax;
> + qparam.cw_max = aCWmax;
> + qparam.cw_min = aCWmin;
> qparam.txop = 0;
> qparam.aifs = 3;
> break;
These are correct fixes.
> case 1: /* AC_VI */
> - qparam.cw_max = aCWmin;
> + qparam.cw_max = aCWmax;
> qparam.cw_min = (aCWmin + 1) / 2 - 1;
> if (use_11b)
> qparam.txop = 6016/32;
> @@ -679,7 +679,7 @@ void ieee80211_set_wmm_default(struct ieee80211_sub_if_data *sdata)
> qparam.aifs = 2;
> break;
> case 0: /* AC_VO */
> - qparam.cw_max = (aCWmin + 1) / 2 - 1;
> + qparam.cw_max = (aCWmax + 1) / 2 - 1;
> qparam.cw_min = (aCWmin + 1) / 4 - 1;
> if (use_11b)
> qparam.txop = 3264/32;
These were actually already correct (yes, it may look like a typo, but
it is not, both of VI and VO are indeed using aCWmin in calculation for
both min and max values) and should not be changed.
- Jouni
WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <jouni.malinen@atheros.com>
To: Jeff Hansen <x@jeffhansen.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/4] mac80211: Fix typos in "set default QoS values according to spec"
Date: Wed, 27 May 2009 08:12:52 +0300 [thread overview]
Message-ID: <1243401172.30310.4.camel@jm-desktop> (raw)
In-Reply-To: <1243400715-13561-4-git-send-email-x@jeffhansen.com>
On Tue, 2009-05-26 at 22:05 -0700, Jeff Hansen wrote:
> Some of the acwmin and acwmax values were backwards in the original patch,
> which cut TX performance (on my device at least) down from ~25-30Mbps to
> 2Mbps. Performance is back up after this commit.
Thanks for reporting these and verifying that this fixes the issue.
However, not all of these are typos.. In addition,
linux-wireless@vger.kernel.org should be cc'ed.
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> @@ -657,20 +657,20 @@ void ieee80211_set_wmm_default(struct ieee80211_sub_if_data *sdata)
>
> switch (queue) {
> case 3: /* AC_BK */
> - qparam.cw_max = aCWmin;
> - qparam.cw_min = aCWmax;
> + qparam.cw_max = aCWmax;
> + qparam.cw_min = aCWmin;
> qparam.txop = 0;
> qparam.aifs = 7;
> break;
> default: /* never happens but let's not leave undefined */
> case 2: /* AC_BE */
> - qparam.cw_max = aCWmin;
> - qparam.cw_min = aCWmax;
> + qparam.cw_max = aCWmax;
> + qparam.cw_min = aCWmin;
> qparam.txop = 0;
> qparam.aifs = 3;
> break;
These are correct fixes.
> case 1: /* AC_VI */
> - qparam.cw_max = aCWmin;
> + qparam.cw_max = aCWmax;
> qparam.cw_min = (aCWmin + 1) / 2 - 1;
> if (use_11b)
> qparam.txop = 6016/32;
> @@ -679,7 +679,7 @@ void ieee80211_set_wmm_default(struct ieee80211_sub_if_data *sdata)
> qparam.aifs = 2;
> break;
> case 0: /* AC_VO */
> - qparam.cw_max = (aCWmin + 1) / 2 - 1;
> + qparam.cw_max = (aCWmax + 1) / 2 - 1;
> qparam.cw_min = (aCWmin + 1) / 4 - 1;
> if (use_11b)
> qparam.txop = 3264/32;
These were actually already correct (yes, it may look like a typo, but
it is not, both of VI and VO are indeed using aCWmin in calculation for
both min and max values) and should not be changed.
- Jouni
next prev parent reply other threads:[~2009-05-27 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 5:05 [ath9k-devel] [PATCH 1/4] ath9k: Reset SC_OP_TSF_RESET flag after stuck beacon Jeff Hansen
2009-05-27 5:05 ` Jeff Hansen
2009-05-27 5:05 ` [ath9k-devel] [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics Jeff Hansen
2009-05-27 5:05 ` Jeff Hansen
2009-05-27 8:51 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2009-05-27 9:02 ` Vasanthakumar Thiagarajan
2009-05-27 9:02 ` Vasanthakumar Thiagarajan
2009-05-27 5:05 ` [ath9k-devel] [PATCH 3/4] ath9k: Add "debug" file to debugfs Jeff Hansen
2009-05-27 5:05 ` Jeff Hansen
2009-05-27 5:05 ` [ath9k-devel] [PATCH 4/4] mac80211: Fix typos in "set default QoS values according to spec" Jeff Hansen
2009-05-27 5:05 ` Jeff Hansen
2009-05-27 5:12 ` Jouni Malinen [this message]
2009-05-27 5:12 ` Jouni Malinen
-- strict thread matches above, loose matches on Subject: below --
2009-05-27 12:48 [ath9k-devel] [PATCH 1/4] ath9k: Reset SC_OP_TSF_RESET flag after stuck beacon Jeff Hansen
2009-05-27 12:48 ` [ath9k-devel] [PATCH 4/4] mac80211: Fix typos in "set default QoS values according to spec" Jeff Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243401172.30310.4.camel@jm-desktop \
--to=jouni.malinen@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.