All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Jeff Hansen <x@jeffhansen.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	Jouni Malinen <Jouni.Malinen@Atheros.com>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics
Date: Wed, 27 May 2009 14:32:59 +0530	[thread overview]
Message-ID: <20090527090258.GJ4584@vasanth-laptop> (raw)
In-Reply-To: <1243400715-13561-2-git-send-email-x@jeffhansen.com>

On Wed, May 27, 2009 at 10:35:13AM +0530, Jeff Hansen wrote:
> +       max = 80 + sc->cur_rate_table->rate_cnt * 64;
> +       buf = vmalloc(max + 1);

I think kmalloc() is the better option here, you are not even
allocating a page, you are allocating 2952B at max.

Vasanth


WARNING: multiple messages have this Message-ID (diff)
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics
Date: Wed, 27 May 2009 14:32:59 +0530	[thread overview]
Message-ID: <20090527090258.GJ4584@vasanth-laptop> (raw)
In-Reply-To: <1243400715-13561-2-git-send-email-x@jeffhansen.com>

On Wed, May 27, 2009 at 10:35:13AM +0530, Jeff Hansen wrote:
> +       max = 80 + sc->cur_rate_table->rate_cnt * 64;
> +       buf = vmalloc(max + 1);

I think kmalloc() is the better option here, you are not even
allocating a page, you are allocating 2952B at max.

Vasanth

  parent reply	other threads:[~2009-05-27  9:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27  5:05 [PATCH 1/4] ath9k: Reset SC_OP_TSF_RESET flag after stuck beacon Jeff Hansen
2009-05-27  5:05 ` [ath9k-devel] " Jeff Hansen
2009-05-27  5:05 ` [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics Jeff Hansen
2009-05-27  5:05   ` [ath9k-devel] " Jeff Hansen
2009-05-27  8:51   ` Vasanthakumar Thiagarajan
2009-05-27  9:02   ` Vasanthakumar Thiagarajan [this message]
2009-05-27  9:02     ` Vasanthakumar Thiagarajan
2009-05-27  5:05 ` [PATCH 3/4] ath9k: Add "debug" file to debugfs Jeff Hansen
2009-05-27  5:05   ` [ath9k-devel] " Jeff Hansen
2009-05-27  5:05 ` [PATCH 4/4] mac80211: Fix typos in "set default QoS values according to spec" Jeff Hansen
2009-05-27  5:05   ` [ath9k-devel] " Jeff Hansen
2009-05-27  5:12   ` Jouni Malinen
2009-05-27  5:12     ` [ath9k-devel] " Jouni Malinen
  -- strict thread matches above, loose matches on Subject: below --
2009-05-27 12:48 [PATCH 1/4] ath9k: Reset SC_OP_TSF_RESET flag after stuck beacon Jeff Hansen
2009-05-27 12:48 ` [PATCH 2/4] ath9k: Combine legacy and 11n rc statistics Jeff Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090527090258.GJ4584@vasanth-laptop \
    --to=vasanth@atheros.com \
    --cc=Jouni.Malinen@Atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=x@jeffhansen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.