From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Warning free build achieved for most platforms
Date: Thu, 11 Jun 2009 13:25:27 -0400 [thread overview]
Message-ID: <1244741127.24612.19.camel@mj> (raw)
Hello!
As of now, GRUB builds without warnings for all platforms except
i386-coreboot. The build is done using gcc 4.4.0 for i386 and x86_64
and gcc 4.3.3 for PowerPC and SPARC64.
Actually, the coreboot warnings should really be errors. In particular,
kern/i386/coreboot/init.c calls grub_at_keyboard_init(), which is not
defined anywhere. It looks like that the coreboot code needs to be
ported to the new terminal handler code.
Also, I noticed that escape sequences are not processed correctly in the
serial code on i386-pc. The fix would be to wait a little bit after the
input bytes arrive to see if they would make an escape sequence. The
problem is still there, but I decided to fix the warning anyway to
encourage warning-free code.
If we want to use -Werror, now it's the time. In fact, it would be good
for the coreboot code too, as its warnings are actually errors.
--
Regards,
Pavel Roskin
next reply other threads:[~2009-06-11 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 17:25 Pavel Roskin [this message]
2009-06-11 17:40 ` Warning free build achieved for most platforms Vladimir 'phcoder' Serbinenko
2009-06-11 17:49 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244741127.24612.19.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.