Warning free build achieved for most platforms

Warning free build achieved for most platforms

[Pavel Roskin]

Hello!

As of now, GRUB builds without warnings for all platforms except
i386-coreboot.  The build is done using gcc 4.4.0 for i386 and x86_64
and gcc 4.3.3 for PowerPC and SPARC64.

Actually, the coreboot warnings should really be errors.  In particular,
kern/i386/coreboot/init.c calls grub_at_keyboard_init(), which is not
defined anywhere.  It looks like that the coreboot code needs to be
ported to the new terminal handler code.

Also, I noticed that escape sequences are not processed correctly in the
serial code on i386-pc.  The fix would be to wait a little bit after the
input bytes arrive to see if they would make an escape sequence.  The
problem is still there, but I decided to fix the warning anyway to
encourage warning-free code.

If we want to use -Werror, now it's the time.  In fact, it would be good
for the coreboot code too, as its warnings are actually errors.

-- 
Regards,
Pavel Roskin

Re: Warning free build achieved for most platforms

[Vladimir 'phcoder' Serbinenko]

Hello

On Thu, Jun 11, 2009 at 7:25 PM, Pavel Roskin<proski@gnu.org> wrote:
> Hello!
>
> As of now, GRUB builds without warnings for all platforms except
> i386-coreboot.  The build is done using gcc 4.4.0 for i386 and x86_64
> and gcc 4.3.3 for PowerPC and SPARC64.
>
It's not entirely true. If you compile under FreeBSD you see a bunch
of warnings coming from the code inside #ifdef __FreeBSD__. Similar
thing happens with Apple's toolchain. It includes warnings
specifically added with #warning to inform about missing not-critical
part of code.
> If we want to use -Werror, now it's the time.  In fact, it would be good
> for the coreboot code too, as its warnings are actually errors.
The problem with -Werror is that different compiling environments
generate different warnings. On gentoo we need either to remove nested
functions or use -Wno-nested-functions.
-Werror could benefit for better code but may happen to break
compilation on some platforms and will make #warning unusable. Such
#warning's are useful because they say the users of less popular
platforms how they can help grub.
I can fix the warnings with FreeBSD. I'll look again at the warnings
with Apple's toolchain but I would actually prefer not to enable
-Werror with Apple's cc because sometimes it generates strange
warnings
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Re: Warning free build achieved for most platforms

[Pavel Roskin]

On Thu, 2009-06-11 at 19:40 +0200, Vladimir 'phcoder' Serbinenko wrote:

> It's not entirely true. If you compile under FreeBSD you see a bunch
> of warnings coming from the code inside #ifdef __FreeBSD__. Similar
> thing happens with Apple's toolchain. It includes warnings
> specifically added with #warning to inform about missing not-critical
> part of code.

OK, fair enough.

-- 
Regards,
Pavel Roskin