From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Proposal for GNU indent compatibility
Date: Fri, 19 Jun 2009 17:52:56 -0400 [thread overview]
Message-ID: <1245448376.672.23.camel@mj> (raw)
In-Reply-To: <d7ead6de0906191001n7340fcbfu8244b60e4b41e582@mail.gmail.com>
On Fri, 2009-06-19 at 19:01 +0200, Vladimir 'phcoder' Serbinenko wrote:
> 8) Removed spaces before labels
Oh, I missed that. I think we should follow GNU indent in the label
placement as well.
> it has put { on new line and without spacing
> Perhaps something more. The patch would be 77280 lines. If someone
> there would be a way to check indent doen't introduce bugs we could
> run it sometimes on all .c files.
I'm sure it doesn't introduce bugs, but it can mangle some code.
My point is that we should accept the code processed by GNU indent
without any additional changes unless GNU indent obviously mangles the
code. There should be no coding conventions that GNU indent doesn't
follow.
I don't think we need to reindent everything.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-06-19 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 16:37 Proposal for GNU indent compatibility Pavel Roskin
2009-06-19 17:01 ` Vladimir 'phcoder' Serbinenko
2009-06-19 21:52 ` Pavel Roskin [this message]
2009-06-21 11:25 ` Robert Millan
2009-06-21 11:41 ` Alfred M. Szmidt
2009-07-31 8:03 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245448376.672.23.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.