All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Proposal for GNU indent compatibility
Date: Fri, 31 Jul 2009 10:03:13 +0200	[thread overview]
Message-ID: <8763d9wa7y.fsf@xs4all.nl> (raw)
In-Reply-To: <1245429440.28417.29.camel@mj> (Pavel Roskin's message of "Fri, 19 Jun 2009 12:37:20 -0400")

Hi,

Pavel Roskin <proski@gnu.org> writes:

> In order to encourage developers to use proper indentation on the newly
> added code, I suggest that we accept the default style of GNU indent.
> That is, the space after "!" should not be needed.  That's the only
> difference I'm aware of.
>
> Running indent on the code and then adding spaces after "!" is
> ridiculous, in my opinion.  GRUB and indent are both GNU programs, it
> should not be needed to do such things.
>
> That doesn't mean that we should start reformatting the existing code.
> Neither does it mean that it's acceptable to submit code that GNU indent
> failed to format nicely.

I do not have a problem with this.  Thus the space change around "!".

--
Marco




      parent reply	other threads:[~2009-07-31  8:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 16:37 Proposal for GNU indent compatibility Pavel Roskin
2009-06-19 17:01 ` Vladimir 'phcoder' Serbinenko
2009-06-19 21:52   ` Pavel Roskin
2009-06-21 11:25 ` Robert Millan
2009-06-21 11:41   ` Alfred M. Szmidt
2009-07-31  8:03 ` Marco Gerards [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763d9wa7y.fsf@xs4all.nl \
    --to=mgerards@xs4all.nl \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.