From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>,
Sean MacLennan <smaclennan@pikatech.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Badness on the Warp
Date: Mon, 22 Jun 2009 08:25:04 +1000 [thread overview]
Message-ID: <1245623104.16880.26.camel@pasglop> (raw)
In-Reply-To: <84144f020906210320n2984807dw2d4b4fb38afd22cf@mail.gmail.com>
On Sun, 2009-06-21 at 13:20 +0300, Pekka Enberg wrote:
> The WARN_ON() is there to let us know that someone is doing a bootmem
> allocation but the slab allocator is already up. So the proper fix
> here is to use kmalloc() directly in the call-site that triggers this
> WARN_ON. I'm cc'ing Ben as he has been taking care of the fall-out
> from my patches on ppc.
>
Right, our interrupt controllers need those fixes, they are low
on my priority list since it's a reasonably harmless warning and I'm
still chasing some actual breakage (though maybe not directly related to
your patches).
Kumar already submitted a couple, Frans, feel free to beat me
at converting UIC (just use kmalloc directly in there instead
of alloc_bootmem).
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Frans Pop <elendil@planet.nl>,
Sean MacLennan <smaclennan@pikatech.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
Paul Mackerras <paulus@samba.org>
Subject: Re: Badness on the Warp
Date: Mon, 22 Jun 2009 08:25:04 +1000 [thread overview]
Message-ID: <1245623104.16880.26.camel@pasglop> (raw)
In-Reply-To: <84144f020906210320n2984807dw2d4b4fb38afd22cf@mail.gmail.com>
On Sun, 2009-06-21 at 13:20 +0300, Pekka Enberg wrote:
> The WARN_ON() is there to let us know that someone is doing a bootmem
> allocation but the slab allocator is already up. So the proper fix
> here is to use kmalloc() directly in the call-site that triggers this
> WARN_ON. I'm cc'ing Ben as he has been taking care of the fall-out
> from my patches on ppc.
>
Right, our interrupt controllers need those fixes, they are low
on my priority list since it's a reasonably harmless warning and I'm
still chasing some actual breakage (though maybe not directly related to
your patches).
Kumar already submitted a couple, Frans, feel free to beat me
at converting UIC (just use kmalloc directly in there instead
of alloc_bootmem).
Cheers,
Ben.
next prev parent reply other threads:[~2009-06-21 22:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 19:48 Badness on the Warp Sean MacLennan
2009-06-20 20:56 ` Frans Pop
2009-06-20 20:56 ` Frans Pop
2009-06-20 23:10 ` Sean MacLennan
2009-06-20 23:26 ` Frans Pop
2009-06-21 4:08 ` Daniel Barkalow
2009-06-21 4:08 ` Daniel Barkalow
2009-06-20 23:42 ` Sean MacLennan
2009-06-21 4:28 ` Frans Pop
2009-06-21 4:28 ` Frans Pop
2009-06-21 10:20 ` Pekka Enberg
2009-06-21 10:20 ` Pekka Enberg
2009-06-21 22:25 ` Benjamin Herrenschmidt [this message]
2009-06-21 22:25 ` Benjamin Herrenschmidt
2009-06-21 22:36 ` Sean MacLennan
2009-06-21 22:36 ` Sean MacLennan
2009-06-21 22:57 ` Benjamin Herrenschmidt
2009-06-21 22:57 ` Benjamin Herrenschmidt
2009-06-22 4:48 ` Pekka Enberg
2009-06-22 4:48 ` Pekka Enberg
2009-06-23 5:24 ` Sean MacLennan
2009-06-23 5:24 ` Sean MacLennan
2009-06-21 7:03 ` H. Peter Anvin
2009-06-21 7:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245623104.16880.26.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.