All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Badness on the Warp
Date: Sat, 20 Jun 2009 22:56:45 +0200	[thread overview]
Message-ID: <200906202256.46073.elendil@planet.nl> (raw)
In-Reply-To: <20090620154824.72b5cd50@lappy.seanm.ca>

> The git bisect returned:
>
> =A0 871fa90791a6f83dd8e2e489feb9534a8c02088d is first bad commit
>
> That is it, no more info.... strange. git show 8714...088d gives:
>
> Merge: 7702667... 79f52b7...
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: =A0 Thu Jun 11 11:27:09 2009 -0700
>
> The Warp has jfs disabled, so I don't know why it would affect us,
> especially this realy in the boot!

The fact that your bisect ended at a merge essentially means that it is=20
invalid. As a merge does not introduce any actual change (unless it=20
includes changes to resolve conflicts), it normally cannot be the cause=20
of a regression.

So either you made a mistake when marking a commit as good or bad during=20
the bisect, or the "badness" does not trigger reliably, resulting in you=20
incorrectly marking a bad commit as good.

My suggestion would be to run the bisection again from the start.

Cheers,
=46JP

WARNING: multiple messages have this Message-ID (diff)
From: Frans Pop <elendil@planet.nl>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Badness on the Warp
Date: Sat, 20 Jun 2009 22:56:45 +0200	[thread overview]
Message-ID: <200906202256.46073.elendil@planet.nl> (raw)
In-Reply-To: <20090620154824.72b5cd50@lappy.seanm.ca>

> The git bisect returned:
>
>   871fa90791a6f83dd8e2e489feb9534a8c02088d is first bad commit
>
> That is it, no more info.... strange. git show 8714...088d gives:
>
> Merge: 7702667... 79f52b7...
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Thu Jun 11 11:27:09 2009 -0700
>
> The Warp has jfs disabled, so I don't know why it would affect us,
> especially this realy in the boot!

The fact that your bisect ended at a merge essentially means that it is 
invalid. As a merge does not introduce any actual change (unless it 
includes changes to resolve conflicts), it normally cannot be the cause 
of a regression.

So either you made a mistake when marking a commit as good or bad during 
the bisect, or the "badness" does not trigger reliably, resulting in you 
incorrectly marking a bad commit as good.

My suggestion would be to run the bisection again from the start.

Cheers,
FJP

  reply	other threads:[~2009-06-20 21:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20 19:48 Badness on the Warp Sean MacLennan
2009-06-20 20:56 ` Frans Pop [this message]
2009-06-20 20:56   ` Frans Pop
2009-06-20 23:10   ` Sean MacLennan
2009-06-20 23:26     ` Frans Pop
2009-06-21  4:08       ` Daniel Barkalow
2009-06-21  4:08         ` Daniel Barkalow
2009-06-20 23:42   ` Sean MacLennan
2009-06-21  4:28     ` Frans Pop
2009-06-21  4:28       ` Frans Pop
2009-06-21 10:20       ` Pekka Enberg
2009-06-21 10:20         ` Pekka Enberg
2009-06-21 22:25         ` Benjamin Herrenschmidt
2009-06-21 22:25           ` Benjamin Herrenschmidt
2009-06-21 22:36           ` Sean MacLennan
2009-06-21 22:36             ` Sean MacLennan
2009-06-21 22:57             ` Benjamin Herrenschmidt
2009-06-21 22:57               ` Benjamin Herrenschmidt
2009-06-22  4:48             ` Pekka Enberg
2009-06-22  4:48               ` Pekka Enberg
2009-06-23  5:24           ` Sean MacLennan
2009-06-23  5:24             ` Sean MacLennan
2009-06-21  7:03   ` H. Peter Anvin
2009-06-21  7:03     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906202256.46073.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=smaclennan@pikatech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.