From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: handle_mm_fault() calling convention cleanup..
Date: Mon, 06 Jul 2009 20:56:16 +1000 [thread overview]
Message-ID: <1246877776.22625.39.camel@pasglop> (raw)
In-Reply-To: <20090706073148.GJ2714@wotan.suse.de>
On Mon, 2009-07-06 at 09:31 +0200, Nick Piggin wrote:
> I have no problems with that. I'd always intended to have flags
> go further up the call chain like Linus did (since we'd discussed
> perhaps making faults interruptible and requiring an extra flag
> to distinguish get_user_pages callers that were not interruptible).
>
> So yes adding more flags to improve code or make things simpler
> is fine by me :)
>
That's before you see my evil plan of bringing the flags all the way
down to set_pte_at() :-)
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch@vger.kernel.org, Hugh Dickins <hugh@veritas.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Wu Fengguang <fengguang.wu@intel.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: handle_mm_fault() calling convention cleanup..
Date: Mon, 06 Jul 2009 20:56:16 +1000 [thread overview]
Message-ID: <1246877776.22625.39.camel@pasglop> (raw)
Message-ID: <20090706105616.Bgl0B2l0QZvNb8Md_2DfY1IeHyoAGjoP-SO-e_zES60@z> (raw)
In-Reply-To: <20090706073148.GJ2714@wotan.suse.de>
On Mon, 2009-07-06 at 09:31 +0200, Nick Piggin wrote:
> I have no problems with that. I'd always intended to have flags
> go further up the call chain like Linus did (since we'd discussed
> perhaps making faults interruptible and requiring an extra flag
> to distinguish get_user_pages callers that were not interruptible).
>
> So yes adding more flags to improve code or make things simpler
> is fine by me :)
>
That's before you see my evil plan of bringing the flags all the way
down to set_pte_at() :-)
Cheers,
Ben.
next prev parent reply other threads:[~2009-07-06 10:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 20:42 handle_mm_fault() calling convention cleanup Linus Torvalds
2009-06-21 20:42 ` Linus Torvalds
2009-06-22 2:20 ` David Miller
2009-06-22 2:20 ` David Miller
2009-06-22 8:10 ` Ingo Molnar
2009-06-22 8:10 ` Ingo Molnar
2009-06-22 9:26 ` Martin Schwidefsky
2009-06-22 9:26 ` Martin Schwidefsky
2009-06-22 14:22 ` David Howells
2009-06-22 14:22 ` David Howells
2009-06-22 14:58 ` James Bottomley
2009-06-22 14:58 ` James Bottomley
2009-06-22 15:49 ` Russell King
2009-06-22 15:49 ` Russell King
2009-06-23 7:18 ` Nick Piggin
2009-06-23 7:18 ` Nick Piggin
2009-06-23 12:49 ` [PATCH] hugetlb: fault flags instead of write_access Hugh Dickins
2009-06-23 12:56 ` Wu Fengguang
2009-06-23 21:36 ` Rik van Riel
2009-06-29 12:29 ` Mel Gorman
2009-06-23 12:52 ` [PATCH] mm: don't rely on flags coincidence Hugh Dickins
2009-06-23 13:00 ` Wu Fengguang
2009-06-23 21:38 ` Rik van Riel
2009-07-03 23:35 ` handle_mm_fault() calling convention cleanup Benjamin Herrenschmidt
2009-07-03 23:35 ` Benjamin Herrenschmidt
2009-07-04 16:44 ` Linus Torvalds
2009-07-04 16:44 ` Linus Torvalds
2009-07-04 21:08 ` Benjamin Herrenschmidt
2009-07-04 21:08 ` Benjamin Herrenschmidt
2009-07-06 7:31 ` Nick Piggin
2009-07-06 7:31 ` Nick Piggin
2009-07-06 10:56 ` Benjamin Herrenschmidt [this message]
2009-07-06 10:56 ` Benjamin Herrenschmidt
2009-07-06 11:53 ` Nick Piggin
2009-07-06 11:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246877776.22625.39.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hugh@veritas.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.