From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: linux-arch@vger.kernel.org, hugh@veritas.com, npiggin@suse.de,
akpm@linux-foundation.org, linux-mm@kvack.org,
fengguang.wu@intel.com, mingo@elte.hu
Subject: Re: handle_mm_fault() calling convention cleanup..
Date: Sun, 21 Jun 2009 19:20:01 -0700 (PDT) [thread overview]
Message-ID: <20090621.192001.46889618.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.01.0906211331480.3240@localhost.localdomain>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 21 Jun 2009 13:42:35 -0700 (PDT)
> I fixed up all architectures that I noticed (at least microblaze had been
> added since the original patches in April), but arch maintainers should
> double-check. Arch maintainers might also want to check whether the
> mindless conversion of
>
> 'is_write' => 'is_write ? FAULT_FLAGS_WRITE : 0'
>
> might perhaps be written in some more natural way (for example, maybe
> you'd like to get rid of 'iswrite' as a variable entirely, and replace it
> with a 'fault_flags' variable).
>
> It's pushed out and tested on x86-64, but it really was such a mindless
> conversion that I hope it works on all architectures. But I thought I'd
> better give people a shout-out regardless.
Sparc looks good, and sparc64 seems to work fine.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: linux-arch@vger.kernel.org, hugh@veritas.com, npiggin@suse.de,
akpm@linux-foundation.org, linux-mm@kvack.org,
fengguang.wu@intel.com, mingo@elte.hu
Subject: Re: handle_mm_fault() calling convention cleanup..
Date: Sun, 21 Jun 2009 19:20:01 -0700 (PDT) [thread overview]
Message-ID: <20090621.192001.46889618.davem@davemloft.net> (raw)
Message-ID: <20090622022001.p5NYWBlBTfJQf59uveYWrFvdvZhO1YjncpoW0eXShZ0@z> (raw)
In-Reply-To: <alpine.LFD.2.01.0906211331480.3240@localhost.localdomain>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 21 Jun 2009 13:42:35 -0700 (PDT)
> I fixed up all architectures that I noticed (at least microblaze had been
> added since the original patches in April), but arch maintainers should
> double-check. Arch maintainers might also want to check whether the
> mindless conversion of
>
> 'is_write' => 'is_write ? FAULT_FLAGS_WRITE : 0'
>
> might perhaps be written in some more natural way (for example, maybe
> you'd like to get rid of 'iswrite' as a variable entirely, and replace it
> with a 'fault_flags' variable).
>
> It's pushed out and tested on x86-64, but it really was such a mindless
> conversion that I hope it works on all architectures. But I thought I'd
> better give people a shout-out regardless.
Sparc looks good, and sparc64 seems to work fine.
next prev parent reply other threads:[~2009-06-22 2:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 20:42 handle_mm_fault() calling convention cleanup Linus Torvalds
2009-06-21 20:42 ` Linus Torvalds
2009-06-22 2:20 ` David Miller [this message]
2009-06-22 2:20 ` David Miller
2009-06-22 8:10 ` Ingo Molnar
2009-06-22 8:10 ` Ingo Molnar
2009-06-22 9:26 ` Martin Schwidefsky
2009-06-22 9:26 ` Martin Schwidefsky
2009-06-22 14:22 ` David Howells
2009-06-22 14:22 ` David Howells
2009-06-22 14:58 ` James Bottomley
2009-06-22 14:58 ` James Bottomley
2009-06-22 15:49 ` Russell King
2009-06-22 15:49 ` Russell King
2009-06-23 7:18 ` Nick Piggin
2009-06-23 7:18 ` Nick Piggin
2009-06-23 12:49 ` [PATCH] hugetlb: fault flags instead of write_access Hugh Dickins
2009-06-23 12:56 ` Wu Fengguang
2009-06-23 21:36 ` Rik van Riel
2009-06-29 12:29 ` Mel Gorman
2009-06-23 12:52 ` [PATCH] mm: don't rely on flags coincidence Hugh Dickins
2009-06-23 13:00 ` Wu Fengguang
2009-06-23 21:38 ` Rik van Riel
2009-07-03 23:35 ` handle_mm_fault() calling convention cleanup Benjamin Herrenschmidt
2009-07-03 23:35 ` Benjamin Herrenschmidt
2009-07-04 16:44 ` Linus Torvalds
2009-07-04 16:44 ` Linus Torvalds
2009-07-04 21:08 ` Benjamin Herrenschmidt
2009-07-04 21:08 ` Benjamin Herrenschmidt
2009-07-06 7:31 ` Nick Piggin
2009-07-06 7:31 ` Nick Piggin
2009-07-06 10:56 ` Benjamin Herrenschmidt
2009-07-06 10:56 ` Benjamin Herrenschmidt
2009-07-06 11:53 ` Nick Piggin
2009-07-06 11:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090621.192001.46889618.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hugh@veritas.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.