From: Tim Post <echo@echoreply.us>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "Xu, Dongxiao" <dongxiao.xu@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"keir.fraser@eu.citrix.com" <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Fix xentop on pv-ops domain0
Date: Tue, 07 Jul 2009 00:02:09 +0800 [thread overview]
Message-ID: <1246896129.5517.287.camel@localhost.localdomain> (raw)
In-Reply-To: <200907061749.29633.Christoph.Egger@amd.com>
Hi,
On Mon, 2009-07-06 at 17:49 +0200, Christoph Egger wrote:
> This patch is good.
>
The following is going to break xenstat on almost every forward port of
2.6.18.8 (including Andy's 2.6.30 vanilla port):
+ if (strncmp(system_info.release, "2.6.18.8-xen",
+ sizeof("2.6.18.8-xen")) == 0)
+ sysfs_vbd_path = "/sys/devices/xen-backend/";
+ else
+ sysfs_vbd_path = "/sys/devices/";
+
I would really recommend considering just
using /sys/bus/xen-backend/devices, as Stephen noted.
Cheers,
--Tim
next prev parent reply other threads:[~2009-07-06 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 13:08 [PATCH] Fix xentop on pv-ops domain0 Xu, Dongxiao
2009-07-06 13:34 ` Christoph Egger
2009-07-06 14:08 ` Xu, Dongxiao
2009-07-06 15:49 ` Christoph Egger
2009-07-06 16:02 ` Tim Post [this message]
2009-07-07 0:37 ` Xu, Dongxiao
2009-07-07 7:15 ` Keir Fraser
2009-07-07 7:59 ` Xu, Dongxiao
-- strict thread matches above, loose matches on Subject: below --
2009-07-06 14:50 Steven Maresca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246896129.5517.287.camel@localhost.localdomain \
--to=echo@echoreply.us \
--cc=Christoph.Egger@amd.com \
--cc=dongxiao.xu@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.