All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Cc: "Xu, Dongxiao" <dongxiao.xu@intel.com>,
	"keir.fraser@eu.citrix.com" <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Fix xentop on pv-ops domain0
Date: Mon, 6 Jul 2009 15:34:31 +0200	[thread overview]
Message-ID: <200907061534.31677.Christoph.Egger@amd.com> (raw)
In-Reply-To: <EADF0A36011179459010BDF5142A457501C9F46DA5@pdsmsx502.ccr.corp.intel.com>

On Monday 06 July 2009 15:08:06 Xu, Dongxiao wrote:
> Xentop encounters error in pv-ops domain0, because the VBD path in sysfs
> changes to "/sys/devices" Also delete the macro in xenstat_netbsd.c,
> because it is not used.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>

Can you move the Linux specific code you add in xentop.c into xenstat_linux.c, 
please? This is an abstraction violation, otherwise.

Thanks,
Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2009-07-06 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-06 13:08 [PATCH] Fix xentop on pv-ops domain0 Xu, Dongxiao
2009-07-06 13:34 ` Christoph Egger [this message]
2009-07-06 14:08   ` Xu, Dongxiao
2009-07-06 15:49     ` Christoph Egger
2009-07-06 16:02       ` Tim Post
2009-07-07  0:37         ` Xu, Dongxiao
2009-07-07  7:15           ` Keir Fraser
2009-07-07  7:59             ` Xu, Dongxiao
  -- strict thread matches above, loose matches on Subject: below --
2009-07-06 14:50 Steven Maresca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907061534.31677.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=dongxiao.xu@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.