All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] enable buildable targets by default
Date: Sat, 18 Jul 2009 18:54:49 -0400	[thread overview]
Message-ID: <1247957689.3416.74.camel@mj> (raw)
In-Reply-To: <d7ead6de0907181438h27830827q5f606c7048a0aaa8@mail.gmail.com>

On Sat, 2009-07-18 at 23:38 +0200, Vladimir 'phcoder' Serbinenko wrote:

> > I fully agree.  The idea with my proposal (we talked this on IRC, I think)
> > was to simplify things, so I proposed that we enable everything so we don't
> > have to provide flags, etc.
> The main pro was to avoid frequent breakage as we experienced with grub-emu.

I just use a script to build grub for all supported platforms with all
supported options.  It's quite good for finding such errors.  As it
stands now, there are no errors and no warnings.  But it took a while to
fix everything.

I think we should eventually revert to not building debug tools by
default.

> > I prefer if we got rid of the flags, or at least most of them (lumping them
> > together with a flag to disable debug tools or so),

I agree.  grub-emu, grub-fstest and efiemu are debug tools.  Neither is
needed for normal operation on any platform.

> I'm undecided on this point. On one hand they can be useful if used
> correctly on the other hand if removing them would avoid users doing
> errors

What kind of errors do you mean?

> > and remove the summary
> > message as well.
> >
> However I really think summary message should remain. It avoids
> developpers to scroll through tons of messages to find out if the part
> they need is built and if it isn't why

The summary message is OK with me, be we should keep it short and to the
point.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-07-18 22:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 13:34 [PATCH] enable buildable targets by default Vladimir 'phcoder' Serbinenko
2009-07-16 16:39 ` Vladimir 'phcoder' Serbinenko
2009-07-17  0:37   ` Pavel Roskin
     [not found]     ` <d7ead6de0907170221h1a204f75ucca48e46c1ff3611@mail.gmail.com>
2009-07-17 14:49       ` Pavel Roskin
2009-07-18 17:55         ` Robert Millan
     [not found]           ` <d7ead6de0907181141n170ec55fueb9d0dccc365cdf3@mail.gmail.com>
2009-07-18 21:38             ` Vladimir 'phcoder' Serbinenko
2009-07-18 22:54               ` Pavel Roskin [this message]
2009-07-22 17:02                 ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247957689.3416.74.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.