Re: [PATCH] enable buildable targets by default

[Robert Millan <rmh@aybabtu.com>]

On Sat, Jul 18, 2009 at 06:54:49PM -0400, Pavel Roskin wrote:
> On Sat, 2009-07-18 at 23:38 +0200, Vladimir 'phcoder' Serbinenko wrote:
> 
> > > I fully agree.  The idea with my proposal (we talked this on IRC, I think)
> > > was to simplify things, so I proposed that we enable everything so we don't
> > > have to provide flags, etc.
> > The main pro was to avoid frequent breakage as we experienced with grub-emu.
> 
> I just use a script to build grub for all supported platforms with all
> supported options.  It's quite good for finding such errors.  As it
> stands now, there are no errors and no warnings.  But it took a while to
> fix everything.
> 
> I think we should eventually revert to not building debug tools by
> default.

Your script can detect regressions once they're committed, but enabling
them by default helps prevents them from being committed in first place.  I
think it's an advantage.

> > > I prefer if we got rid of the flags, or at least most of them (lumping them
> > > together with a flag to disable debug tools or so),
> 
> I agree.  grub-emu, grub-fstest and efiemu are debug tools.  Neither is
> needed for normal operation on any platform.

I think efiemu is needed for some loaders.  It's not a debug tool AFAIK.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."