All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: akpm@linux-foundation.org
Cc: containers@lists.linux-foundation.org, bblum@google.com,
	linux-kernel@vger.kernel.org, menage@google.com,
	vda.linux@googlemail.com, mikew@google.com
Subject: Re: [RFCv2][PATCH] flexible array implementation
Date: Tue, 21 Jul 2009 15:09:05 -0700	[thread overview]
Message-ID: <1248214145.13249.5671.camel@nimitz> (raw)
In-Reply-To: <20090721220017.60A219D3@kernel>

On Tue, 2009-07-21 at 15:00 -0700, Dave Hansen wrote:
> 
> The interface is dirt simple.  4 functions:
>         alloc_flex_array()
>         free_flex_array()
>         flex_array_put()
>         flex_array_get()
> 
> put() appends an item into the array while get() takes
> indexes and does array-style access.

I need to update this description, but the kerneldoc comments are up to
date.

That reminds me...  People will get somewhat weird behavior if they mix
flex_array_append() and flex_array_put().  Is that OK?  Should
flex_array_put() modify ->nr_elements to point to the element past the
one that was just put()?  Should we perhaps drop the append() function
and the ->nr_elements variable completely?

-- Dave


  parent reply	other threads:[~2009-07-21 22:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 22:00 [RFCv2][PATCH] flexible array implementation Dave Hansen
2009-07-21 22:09 ` Dave Hansen
2009-07-21 22:09 ` Dave Hansen [this message]
2009-07-21 22:35   ` Andrew Morton
2009-07-21 22:35   ` Andrew Morton
2009-07-22  3:25 ` Li Zefan
     [not found]   ` <4A66868F.4010001-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-22  4:34     ` Dave Hansen
2009-07-22  4:34   ` Dave Hansen
2009-07-22  6:14     ` Li Zefan
2009-07-22  6:14     ` Li Zefan
2009-07-22  3:25 ` Li Zefan
2009-07-22  7:09 ` Amerigo Wang
     [not found]   ` <20090722070903.GG6281-+dguKlz9DXUf7BdofF/totBPR1lH4CV8@public.gmane.org>
2009-07-22 15:02     ` Dave Hansen
2009-07-22 15:02   ` Dave Hansen
2009-07-22  7:09 ` Amerigo Wang
2009-07-22 18:30 ` Matt Helsley
2009-07-22 22:03   ` Dave Hansen
     [not found]   ` <20090722183018.GE5878-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-22 22:03     ` Dave Hansen
2009-07-22 18:30 ` Matt Helsley
2009-07-22 19:55 ` Mike Waychison
2009-07-22 19:55   ` Mike Waychison
2009-07-22 22:00   ` Dave Hansen
     [not found]   ` <4A676ECC.1090400-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2009-07-22 22:00     ` Dave Hansen
2009-07-22 20:57 ` Benjamin Blum
     [not found]   ` <2f86c2480907221357j5a09fd9au890f815db3750187-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-22 21:51     ` Dave Hansen
2009-07-22 21:51       ` Dave Hansen
2009-07-22 23:20       ` Benjamin Blum
2009-07-22 23:20       ` Benjamin Blum
     [not found]         ` <2f86c2480907221620u6da3a8e3h8273f6a9ee156f86-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-23  5:41           ` Dave Hansen
2009-07-23  5:41         ` Dave Hansen
2009-07-22 20:57 ` Benjamin Blum
2009-07-23  2:45 ` H. Peter Anvin
     [not found]   ` <4A67CEB7.2080505-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-07-23 14:30     ` Dave Hansen
2009-07-23 14:30       ` Dave Hansen
2009-07-23  2:45 ` H. Peter Anvin
  -- strict thread matches above, loose matches on Subject: below --
2009-07-21 22:00 Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248214145.13249.5671.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bblum@google.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=mikew@google.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.