All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Amerigo Wang <xiyou.wangcong@gmail.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
	bblum@google.com, linux-kernel@vger.kernel.org,
	menage@google.com, vda.linux@googlemail.com, mikew@google.com
Subject: Re: [RFCv2][PATCH] flexible array implementation
Date: Wed, 22 Jul 2009 08:02:35 -0700	[thread overview]
Message-ID: <1248274955.24021.5.camel@nimitz> (raw)
In-Reply-To: <20090722070903.GG6281@cr0.nay.redhat.com>

On Wed, 2009-07-22 at 15:09 +0800, Amerigo Wang wrote:
> On Tue, Jul 21, 2009 at 03:00:17PM -0700, Dave Hansen wrote:
> >+static inline int __nr_part_ptrs(void)
> 
> How about __nr_ptrs_in_part()?

That would be fine except it is the number of part pointers in the base.
I guess you're proving that I named it horribly. :)

> >+static int fa_index_inside_part(struct flex_array *fa, int element_nr)
> >+{
> >+	return (element_nr % __elements_per_part(fa->element_size));
> >+}
> >+
> >+static int offset_inside_part(struct flex_array *fa, int element_nr)
> 
> How about index_in_part()?

Yeah, I guess that's decent.  I'll go see how it feels when it gets
used.

-- Dave


  reply	other threads:[~2009-07-22 15:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 22:00 [RFCv2][PATCH] flexible array implementation Dave Hansen
2009-07-21 22:09 ` Dave Hansen
2009-07-21 22:35   ` Andrew Morton
2009-07-21 22:35   ` Andrew Morton
2009-07-21 22:09 ` Dave Hansen
2009-07-22  3:25 ` Li Zefan
2009-07-22  3:25 ` Li Zefan
     [not found]   ` <4A66868F.4010001-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-22  4:34     ` Dave Hansen
2009-07-22  4:34   ` Dave Hansen
2009-07-22  6:14     ` Li Zefan
2009-07-22  6:14     ` Li Zefan
2009-07-22  7:09 ` Amerigo Wang
2009-07-22 15:02   ` Dave Hansen [this message]
     [not found]   ` <20090722070903.GG6281-+dguKlz9DXUf7BdofF/totBPR1lH4CV8@public.gmane.org>
2009-07-22 15:02     ` Dave Hansen
2009-07-22  7:09 ` Amerigo Wang
2009-07-22 18:30 ` Matt Helsley
     [not found]   ` <20090722183018.GE5878-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-07-22 22:03     ` Dave Hansen
2009-07-22 22:03   ` Dave Hansen
2009-07-22 18:30 ` Matt Helsley
2009-07-22 19:55 ` Mike Waychison
2009-07-22 19:55   ` Mike Waychison
2009-07-22 22:00   ` Dave Hansen
     [not found]   ` <4A676ECC.1090400-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2009-07-22 22:00     ` Dave Hansen
2009-07-22 20:57 ` Benjamin Blum
     [not found]   ` <2f86c2480907221357j5a09fd9au890f815db3750187-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-22 21:51     ` Dave Hansen
2009-07-22 21:51       ` Dave Hansen
2009-07-22 23:20       ` Benjamin Blum
2009-07-23  5:41         ` Dave Hansen
     [not found]         ` <2f86c2480907221620u6da3a8e3h8273f6a9ee156f86-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-23  5:41           ` Dave Hansen
2009-07-22 23:20       ` Benjamin Blum
2009-07-22 20:57 ` Benjamin Blum
2009-07-23  2:45 ` H. Peter Anvin
2009-07-23  2:45 ` H. Peter Anvin
     [not found]   ` <4A67CEB7.2080505-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-07-23 14:30     ` Dave Hansen
2009-07-23 14:30       ` Dave Hansen
  -- strict thread matches above, loose matches on Subject: below --
2009-07-21 22:00 Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248274955.24021.5.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bblum@google.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=mikew@google.com \
    --cc=vda.linux@googlemail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.