ceph performance call: buffer

ceph performance call: buffer

[Matt W. Benjamin]

Hi Folks,

Per yesterday's Ceph performance call, we've pushed 2 wip branches for review and feedback to https://github.com/linuxbox2/linuxbox-ceph.git .

1. xio-v084-inline reorganizes ceph::buffer as a namespace, and (nearly) all of
buffer::hash, buffer::ptr and buffer::list as inline

2. xio-v084-inline-flat restores some raw encapsulation lost in the prior change,
then refactors buffer::raw to remove virtual methods

We've made some effort to measure the impact of the changes, but don't have
reliable data yet.  (It's possible that our initial impression of improvement from the inlining change was not accurate, but more likely we need better workload tests.)

In addition, we've been working on an experiment to refactor buffer::ptr and buffer::raw to use boost::intrusive::list, to unify the interfaces of the two types to permit interning buffer::raw directly on the containing list when there is no sharing, and a slab allocator for both types.  We plan to push a wip branch with these changes to when they've stabilized a bit more and/or we have real perf numbers.

Thanks,

Matt

-- 
Matt Benjamin
CohortFS, LLC.
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://cohortfs.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 

Re: ceph performance call: buffer

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Hi Matt,

You will probably be interested in


On 16/10/2014 11:00, Matt W. Benjamin wrote:
> Hi Folks,
> 
> Per yesterday's Ceph performance call, we've pushed 2 wip branches for review and feedback to https://github.com/linuxbox2/linuxbox-ceph.git .
> 
> 1. xio-v084-inline reorganizes ceph::buffer as a namespace, and (nearly) all of
> buffer::hash, buffer::ptr and buffer::list as inline
> 
> 2. xio-v084-inline-flat restores some raw encapsulation lost in the prior change,
> then refactors buffer::raw to remove virtual methods
> 
> We've made some effort to measure the impact of the changes, but don't have
> reliable data yet.  (It's possible that our initial impression of improvement from the inlining change was not accurate, but more likely we need better workload tests.)
> 
> In addition, we've been working on an experiment to refactor buffer::ptr and buffer::raw to use boost::intrusive::list, to unify the interfaces of the two types to permit interning buffer::raw directly on the containing list when there is no sharing, and a slab allocator for both types.  We plan to push a wip branch with these changes to when they've stabilized a bit more and/or we have real perf numbers.
> 
> Thanks,
> 
> Matt
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: ceph performance call: buffer

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]

Hi Again,

On 16/10/2014 11:16, Loic Dachary wrote:
> Hi Matt,
> 
> You will probably be interested in

(I have to find which sequence of keys send out the mail by accident... :-)

https://github.com/ceph/ceph/pull/2595

and

https://github.com/dachary/ceph/commit/734e555c640a3b5e9bbf0329bd524cffaca61c4f

in particular. It does not do anything performance wise but it's going to be merged in the not-to-distant future.

Cheers

> 
> On 16/10/2014 11:00, Matt W. Benjamin wrote:
>> Hi Folks,
>>
>> Per yesterday's Ceph performance call, we've pushed 2 wip branches for review and feedback to https://github.com/linuxbox2/linuxbox-ceph.git .
>>
>> 1. xio-v084-inline reorganizes ceph::buffer as a namespace, and (nearly) all of
>> buffer::hash, buffer::ptr and buffer::list as inline
>>
>> 2. xio-v084-inline-flat restores some raw encapsulation lost in the prior change,
>> then refactors buffer::raw to remove virtual methods
>>
>> We've made some effort to measure the impact of the changes, but don't have
>> reliable data yet.  (It's possible that our initial impression of improvement from the inlining change was not accurate, but more likely we need better workload tests.)
>>
>> In addition, we've been working on an experiment to refactor buffer::ptr and buffer::raw to use boost::intrusive::list, to unify the interfaces of the two types to permit interning buffer::raw directly on the containing list when there is no sharing, and a slab allocator for both types.  We plan to push a wip branch with these changes to when they've stabilized a bit more and/or we have real perf numbers.
>>
>> Thanks,
>>
>> Matt
>>
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: ceph performance call: buffer

[Matt W. Benjamin]

Ack, very interested in that :).

Matt

----- "Loic Dachary" <loic@dachary.org> wrote:

> Hi Again,
> 
> On 16/10/2014 11:16, Loic Dachary wrote:
> > Hi Matt,
> > 
> > You will probably be interested in
> 
> (I have to find which sequence of keys send out the mail by
> accident... :-)
> 
> https://github.com/ceph/ceph/pull/2595
> 
> and
> 
> https://github.com/dachary/ceph/commit/734e555c640a3b5e9bbf0329bd524cffaca61c4f
> 
> in particular. It does not do anything performance wise but it's going
> to be merged in the not-to-distant future.
> 
> Cheers
> 
> > 
> > On 16/10/2014 11:00, Matt W. Benjamin wrote:
> >> Hi Folks,
> >>
> >> Per yesterday's Ceph performance call, we've pushed 2 wip branches
> for review and feedback to
> https://github.com/linuxbox2/linuxbox-ceph.git .
> >>
> >> 1. xio-v084-inline reorganizes ceph::buffer as a namespace, and
> (nearly) all of
> >> buffer::hash, buffer::ptr and buffer::list as inline
> >>
> >> 2. xio-v084-inline-flat restores some raw encapsulation lost in the
> prior change,
> >> then refactors buffer::raw to remove virtual methods
> >>
> >> We've made some effort to measure the impact of the changes, but
> don't have
> >> reliable data yet.  (It's possible that our initial impression of
> improvement from the inlining change was not accurate, but more likely
> we need better workload tests.)
> >>
> >> In addition, we've been working on an experiment to refactor
> buffer::ptr and buffer::raw to use boost::intrusive::list, to unify
> the interfaces of the two types to permit interning buffer::raw
> directly on the containing list when there is no sharing, and a slab
> allocator for both types.  We plan to push a wip branch with these
> changes to when they've stabilized a bit more and/or we have real perf
> numbers.
> >>
> >> Thanks,
> >>
> >> Matt
> >>
> > 
> 
> -- 
> Loïc Dachary, Artisan Logiciel Libre

-- 
Matt Benjamin
CohortFS, LLC.
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://cohortfs.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html