From: Daniel Walker <dwalker@fifo99.com>
To: Ed Cashin <ecashin@coraid.com>
Cc: jens.axboe@oracle.com, akpm@linux-foundation.org,
apw@canonical.com, bonbons@linux-vserver.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: end barrier bios with EOPNOTSUPP
Date: Wed, 09 Sep 2009 09:51:29 -0700 [thread overview]
Message-ID: <1252515089.14793.126.camel@desktop> (raw)
In-Reply-To: <60772f633c524ba873f569966fccd6ce@coraid.com>
On Wed, 2009-09-09 at 12:45 -0400, Ed Cashin wrote:
> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -172,6 +172,9 @@ aoeblk_make_request(struct request_queue *q,
> struct bio *bio)
> BUG();
> bio_endio(bio, -ENXIO);
> return 0;
> + } else if (bio_barrier(bio)) {
> + bio_endio(bio, -EOPNOTSUPP);
> + return 0;
> } else if (bio->bi_io_vec == NULL) {
> printk(KERN_ERR "aoe: bi_io_vec is NULL\n");
> BUG();
Could you run this through script/checkpatch.pl and fix any errors you
find.. It looks like your not indenting properly ..
Daniel
next prev parent reply other threads:[~2009-09-09 16:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 19:55 + aoe-ensure-we-initialise-the-request_queue-correctly.patch added to -mm tree akpm
[not found] ` <20090903063539.GH12579@kernel.dk>
[not found] ` <2339aa04a4e8fb440a52624273728352@coraid.com>
[not found] ` <20090904183525.GB18599@kernel.dk>
[not found] ` <f48e25c99e41e375f2ddd85989cd39e1@coraid.com>
[not found] ` <20090905051735.GH18599@kernel.dk>
[not found] ` <366469f19c41e0150028b886f6859019@coraid.com>
[not found] ` <20090908193540.GB18599@kernel.dk>
2009-09-09 16:45 ` [PATCH] aoe: end barrier bios with EOPNOTSUPP Ed Cashin
2009-09-09 16:50 ` Ed Cashin
2009-09-09 19:03 ` Ed Cashin
2009-09-09 16:51 ` Daniel Walker [this message]
2009-09-09 17:08 ` Alan Cox
2009-09-09 18:00 ` Ed Cashin
2009-09-09 20:58 ` Jens Axboe
2009-09-09 21:23 ` Ed Cashin
2009-09-10 7:48 ` Jens Axboe
2009-09-10 15:16 ` Ed Cashin
2009-09-10 19:50 ` Jens Axboe
2009-09-10 20:03 ` Ed Cashin
2009-09-10 20:07 ` Jens Axboe
2009-09-10 20:20 ` Ed Cashin
2009-09-10 20:27 ` Ed Cashin
2009-09-10 20:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252515089.14793.126.camel@desktop \
--to=dwalker@fifo99.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bonbons@linux-vserver.org \
--cc=ecashin@coraid.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.