From: Ed Cashin <ecashin@coraid.com>
To: jens.axboe@oracle.com, ecashin@coraid.com,
alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org,
apw@canonical.com, bonbons@linux-vserver.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: end barrier bios with EOPNOTSUPP
Date: Wed, 9 Sep 2009 17:23:49 -0400 [thread overview]
Message-ID: <810bbe1723b0a205f9b5018a5ddaa722@coraid.com> (raw)
In-Reply-To: <20090909205835.GK18599@kernel.dk>
On Wed Sep 9 16:59:30 EDT 2009, jens.axboe@oracle.com wrote:
> On Wed, Sep 09 2009, Ed Cashin wrote:
...
> > To implement the barrier, [aoe] would stop generating new AoE write
> > commands, wait for AoE write responses for all the outstanding write
> > commands, issue the ATA cache flush command, wait for the response to
> > the flush, and then resume normal activity.
>
> That's how barriers work with sata to begin with, so I'd very much
> recommend that you do the same in aoe instead of just not supporting it.
This patch with EOPNOTSUPP just fixes the regression in 2.6.31-rc9.
A patch adding support for barriers would be nice. Since I have
limited time I tried to motivate that work by using the torture tests
that Chris Mason (I believe it was) posted a while ago, but I could
not get any problems to manifest using that torture test.
If I had a reproducable problem case that the barrier implementation
could fix, it would be very helpful.
--
Ed
next prev parent reply other threads:[~2009-09-09 21:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 19:55 + aoe-ensure-we-initialise-the-request_queue-correctly.patch added to -mm tree akpm
[not found] ` <20090903063539.GH12579@kernel.dk>
[not found] ` <2339aa04a4e8fb440a52624273728352@coraid.com>
[not found] ` <20090904183525.GB18599@kernel.dk>
[not found] ` <f48e25c99e41e375f2ddd85989cd39e1@coraid.com>
[not found] ` <20090905051735.GH18599@kernel.dk>
[not found] ` <366469f19c41e0150028b886f6859019@coraid.com>
[not found] ` <20090908193540.GB18599@kernel.dk>
2009-09-09 16:45 ` [PATCH] aoe: end barrier bios with EOPNOTSUPP Ed Cashin
2009-09-09 16:50 ` Ed Cashin
2009-09-09 19:03 ` Ed Cashin
2009-09-09 16:51 ` Daniel Walker
2009-09-09 17:08 ` Alan Cox
2009-09-09 18:00 ` Ed Cashin
2009-09-09 20:58 ` Jens Axboe
2009-09-09 21:23 ` Ed Cashin [this message]
2009-09-10 7:48 ` Jens Axboe
2009-09-10 15:16 ` Ed Cashin
2009-09-10 19:50 ` Jens Axboe
2009-09-10 20:03 ` Ed Cashin
2009-09-10 20:07 ` Jens Axboe
2009-09-10 20:20 ` Ed Cashin
2009-09-10 20:27 ` Ed Cashin
2009-09-10 20:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=810bbe1723b0a205f9b5018a5ddaa722@coraid.com \
--to=ecashin@coraid.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=apw@canonical.com \
--cc=bonbons@linux-vserver.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.