All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Ed Cashin <ecashin@coraid.com>
Cc: alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org,
	apw@canonical.com, bonbons@linux-vserver.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: end barrier bios with EOPNOTSUPP
Date: Thu, 10 Sep 2009 21:50:21 +0200	[thread overview]
Message-ID: <20090910195021.GW18599@kernel.dk> (raw)
In-Reply-To: <84f18127dcdb4762bf9dc6796846087f@coraid.com>

On Thu, Sep 10 2009, Ed Cashin wrote:
> On Thu Sep 10 03:48:22 EDT 2009, jens.axboe@oracle.com wrote:
> > On Wed, Sep 09 2009, Ed Cashin wrote:
> ...
> > > If I had a reproducable problem case that the barrier implementation
> > > could fix, it would be very helpful.
> > 
> > Depending on timing and the other end, it may not be easy to reproduce.
> > But the problem is indeed real, so I think you should just add the
> > proper barrier implementation instead of spending too much time trying
> > to create a reproducable problem. By the time you get there, you could
> > have fixed it many times over :-)
> 
> OK. I will start work on it.  But if anybody can give me a torture
> test that works on aoe devices, I'll be grateful.
> 
> I think the EOPNOTSUPP patch is good for the for-next aoe quilt tree,
> while the new barrier support will be good for 2.6.32.

.31 is already out, so there's plenty of time to fix it for .32 for
real. I don't mind putting in the temporary fix in the mean time,
though.

-- 
Jens Axboe


  reply	other threads:[~2009-09-10 19:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02 19:55 + aoe-ensure-we-initialise-the-request_queue-correctly.patch added to -mm tree akpm
     [not found] ` <20090903063539.GH12579@kernel.dk>
     [not found]   ` <2339aa04a4e8fb440a52624273728352@coraid.com>
     [not found]     ` <20090904183525.GB18599@kernel.dk>
     [not found]       ` <f48e25c99e41e375f2ddd85989cd39e1@coraid.com>
     [not found]         ` <20090905051735.GH18599@kernel.dk>
     [not found]           ` <366469f19c41e0150028b886f6859019@coraid.com>
     [not found]             ` <20090908193540.GB18599@kernel.dk>
2009-09-09 16:45               ` [PATCH] aoe: end barrier bios with EOPNOTSUPP Ed Cashin
2009-09-09 16:50                 ` Ed Cashin
2009-09-09 19:03                   ` Ed Cashin
2009-09-09 16:51                 ` Daniel Walker
2009-09-09 17:08                 ` Alan Cox
2009-09-09 18:00                   ` Ed Cashin
2009-09-09 20:58                     ` Jens Axboe
2009-09-09 21:23                       ` Ed Cashin
2009-09-10  7:48                         ` Jens Axboe
2009-09-10 15:16                           ` Ed Cashin
2009-09-10 19:50                             ` Jens Axboe [this message]
2009-09-10 20:03                               ` Ed Cashin
2009-09-10 20:07                                 ` Jens Axboe
2009-09-10 20:20                                   ` Ed Cashin
2009-09-10 20:27                                     ` Ed Cashin
2009-09-10 20:29                                       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090910195021.GW18599@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=apw@canonical.com \
    --cc=bonbons@linux-vserver.org \
    --cc=ecashin@coraid.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.