From: Artem Bityutskiy <dedekind1@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"'David Woodhouse'" <dwmw2@infradead.org>
Cc: linux-pcmcia@lists.infradead.org,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-usb@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)
Date: Mon, 26 Oct 2009 12:18:57 +0200 [thread overview]
Message-ID: <1256552337.29885.419.camel@localhost> (raw)
In-Reply-To: <20091026101909.271c109e@lxorguk.ukuu.org.uk>
On Mon, 2009-10-26 at 10:19 +0000, Alan Cox wrote:
> > > No, I don't have all that much PCMCIA hardware -- and specifically none for
> > > the drivers which were modified in this patch (parport, ixj-telephony,
> > > sl811; pcmcia_mtd is marked broken anyway).
> >
> > This driver is old and ugly, and it is even possible that no one uses it
> > anymore, so I guess getting clean-ups without testing is ok for it.
> > However, in that case the clean-up patches should be reviewable, which I
> > wouldn't say about your patch :-)
> >
> > Could you please split it on several smaller patches, each doing one
> > thing only?
>
> pcmcia_mtd has been marked broken for how long - better to delete it ?
> It's in the git history if anyone ever wants to resurrect it.
I do not have objections. David?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-10-26 10:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 19:42 [RFC] more PCMCIA cleanup patches for 2.6.33 Dominik Brodowski
2009-10-24 19:42 ` [PATCH 04/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (ide) Dominik Brodowski
2009-10-26 15:47 ` Sergei Shtylyov
2009-10-26 15:33 ` Dominik Brodowski
2009-10-24 19:42 ` [PATCH 08/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (net) Dominik Brodowski
2009-10-24 19:42 ` [PATCH 09/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (ray-cs.c) Dominik Brodowski
2009-10-24 19:42 ` Dominik Brodowski
2009-10-24 19:43 ` [PATCH 10/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (wireless) Dominik Brodowski
2009-10-24 19:43 ` Dominik Brodowski
2009-10-24 19:43 ` [PATCH 11/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (scsi) Dominik Brodowski
2009-10-24 20:16 ` Rolf Eike Beer
2009-10-24 20:39 ` Dominik Brodowski
2009-10-24 19:43 ` [PATCH 12/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (serial_cs) Dominik Brodowski
2009-10-24 19:43 ` [PATCH 13/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (sound) Dominik Brodowski
2009-11-02 10:43 ` Takashi Iwai
2009-10-24 19:43 ` [PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers) Dominik Brodowski
2009-10-26 6:42 ` Artem Bityutskiy
2009-10-26 7:13 ` Dominik Brodowski
2009-10-26 7:26 ` Artem Bityutskiy
2009-10-26 7:56 ` Dominik Brodowski
2009-10-26 8:05 ` Artem Bityutskiy
2009-10-26 10:19 ` Alan Cox
2009-10-26 10:18 ` Artem Bityutskiy [this message]
2009-11-03 8:37 ` Artem Bityutskiy
2009-11-07 11:19 ` pcmciamtd -- what's broken, who needs it? Dominik Brodowski
2009-11-07 11:29 ` Komuro
2009-11-07 11:33 ` Dominik Brodowski
2009-11-07 16:57 ` Kristoffer Ericson
2009-11-08 8:12 ` Dominik Brodowski
2009-11-07 22:33 ` Komuro
2009-11-04 10:20 ` PETEC 2MB SRAM Pep Talens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256552337.29885.419.camel@localhost \
--to=dedekind1@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.