Re: [PATCH 04/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (ide)

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Dominik Brodowski wrote:

> ide-cs.c is the only PCMCIA device driver making use of CONFIG_PCMCIA_DEBUG,
> so convert it to use the dynamic debug infrastructure.

> Also, remove all usages of the CS_CHECK macro and replace them with proper
> Linux style calling and return value checking. The extra error reporting may
> be dropped, as the PCMCIA core already complains about any (non-driver-author)
> errors.

> CC: linux-ide@vger.kernel.org
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
> ---
>  drivers/ata/pata_pcmcia.c |   16 ++++++++--------
>  drivers/ide/ide-cs.c      |   32 +++++++++++---------------------
>  2 files changed, 19 insertions(+), 29 deletions(-)

    Please submit as two separate patches as ide and libata are two separate 
subsystems.

WBR, Sergei