From: Adam Litke <agl@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: virtio: Add memory statistics reporting to the balloon driver (V3)
Date: Thu, 19 Nov 2009 10:29:09 -0600 [thread overview]
Message-ID: <1258648149.3464.23.camel@aglitke> (raw)
In-Reply-To: <4B056EB8.9020509@redhat.com>
On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote:
> On 11/19/2009 05:58 PM, Adam Litke wrote:
> > On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
> >
> >> On 11/19/2009 05:19 PM, Adam Litke wrote:
> >>
> >>> Rusty and Anthony,
> >>> If I've addressed all outstanding issues, please consider this patch for
> >>> inclusion. Thanks.
> >>>
> >>> +struct virtio_balloon_stat
> >>> +{
> >>> + __le16 tag;
> >>> + __le64 val;
> >>> +};
> >>> +
> >>>
> >>>
> >> You're not doing endian conversion in the host?
> >>
> > No. I was following by example. For the virtio_balloon, the existing
> > code is careful so that the guest always writes data in little endian.
> >
>
> I don't follow. If the guest is careful to write little-endian, surely
> the host must be equally careful to read little-endian?
That is true and, by my reading of the existing qemu virtio-balloon
device code, isn't virtio_balloon_set_config() on a big endian host
already broken?
--
Thanks,
Adam
WARNING: multiple messages have this Message-ID (diff)
From: Adam Litke <agl@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Anthony Liguori <aliguori@us.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)
Date: Thu, 19 Nov 2009 10:29:09 -0600 [thread overview]
Message-ID: <1258648149.3464.23.camel@aglitke> (raw)
In-Reply-To: <4B056EB8.9020509@redhat.com>
On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote:
> On 11/19/2009 05:58 PM, Adam Litke wrote:
> > On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
> >
> >> On 11/19/2009 05:19 PM, Adam Litke wrote:
> >>
> >>> Rusty and Anthony,
> >>> If I've addressed all outstanding issues, please consider this patch for
> >>> inclusion. Thanks.
> >>>
> >>> +struct virtio_balloon_stat
> >>> +{
> >>> + __le16 tag;
> >>> + __le64 val;
> >>> +};
> >>> +
> >>>
> >>>
> >> You're not doing endian conversion in the host?
> >>
> > No. I was following by example. For the virtio_balloon, the existing
> > code is careful so that the guest always writes data in little endian.
> >
>
> I don't follow. If the guest is careful to write little-endian, surely
> the host must be equally careful to read little-endian?
That is true and, by my reading of the existing qemu virtio-balloon
device code, isn't virtio_balloon_set_config() on a big endian host
already broken?
--
Thanks,
Adam
next prev parent reply other threads:[~2009-11-19 16:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 15:06 [Qemu-devel] virtio: Report new guest memory statistics pertinent to memory ballooning (V4) Adam Litke
2009-11-19 15:19 ` virtio: Add memory statistics reporting to the balloon driver (V3) Adam Litke
2009-11-19 15:19 ` Adam Litke
2009-11-19 15:19 ` [Qemu-devel] " Adam Litke
2009-11-19 15:22 ` Avi Kivity
2009-11-19 15:22 ` [Qemu-devel] " Avi Kivity
2009-11-19 15:22 ` Avi Kivity
2009-11-19 15:58 ` Adam Litke
2009-11-19 15:58 ` [Qemu-devel] " Adam Litke
2009-11-19 16:13 ` Avi Kivity
2009-11-19 16:13 ` Avi Kivity
2009-11-19 16:13 ` [Qemu-devel] " Avi Kivity
2009-11-19 16:29 ` Adam Litke
2009-11-19 16:29 ` Adam Litke [this message]
2009-11-19 16:29 ` [Qemu-devel] " Adam Litke
2009-11-19 15:58 ` Adam Litke
2009-11-19 23:53 ` Rusty Russell
2009-11-19 23:53 ` [Qemu-devel] " Rusty Russell
2009-11-19 23:53 ` Rusty Russell
2009-11-23 9:44 ` Michael S. Tsirkin
2009-11-23 9:44 ` [Qemu-devel] " Michael S. Tsirkin
2009-11-23 11:00 ` Dor Laor
2009-11-23 11:00 ` Dor Laor
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:00 ` Dor Laor
2009-11-23 9:44 ` Michael S. Tsirkin
2009-11-19 15:19 ` [Qemu-devel] Re: virtio: Report new guest memory statistics pertinent to memory ballooning (V4) Avi Kivity
2009-11-19 15:56 ` Adam Litke
2009-11-19 16:02 ` Avi Kivity
2009-11-23 18:47 ` Anthony Liguori
2009-11-20 1:24 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258648149.3464.23.camel@aglitke \
--to=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.