From: Rusty Russell <rusty@rustcorp.com.au>
To: Adam Litke <agl@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: virtio: Add memory statistics reporting to the balloon driver (V3)
Date: Fri, 20 Nov 2009 10:23:30 +1030 [thread overview]
Message-ID: <200911201023.30709.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1258643945.3464.5.camel@aglitke>
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote:
> Rusty and Anthony,
> If I've addressed all outstanding issues, please consider this patch for
> inclusion. Thanks.
>
> Changes since V2:
> - Increase stat field size to 64 bits
> - Report all sizes in kb (not pages)
Hi Adam,
Looks like we're very close. A few minor things:
Why k? Why not just do the simplest possible thing, and just report all
stats as straight numbers, now we have 64 bits.
> - Drop anon_pages stat and fix endianness conversion
Please drop endianness conversion.
> +struct virtio_balloon_stat
> +{
> + __le16 tag;
> + __le64 val;
> +};
Let's not introduce padding as well; __attribute__((packed)) here please.
Thanks,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Anthony Liguori <aliguori@us.ibm.com>,
virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V3)
Date: Fri, 20 Nov 2009 10:23:30 +1030 [thread overview]
Message-ID: <200911201023.30709.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1258643945.3464.5.camel@aglitke>
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote:
> Rusty and Anthony,
> If I've addressed all outstanding issues, please consider this patch for
> inclusion. Thanks.
>
> Changes since V2:
> - Increase stat field size to 64 bits
> - Report all sizes in kb (not pages)
Hi Adam,
Looks like we're very close. A few minor things:
Why k? Why not just do the simplest possible thing, and just report all
stats as straight numbers, now we have 64 bits.
> - Drop anon_pages stat and fix endianness conversion
Please drop endianness conversion.
> +struct virtio_balloon_stat
> +{
> + __le16 tag;
> + __le64 val;
> +};
Let's not introduce padding as well; __attribute__((packed)) here please.
Thanks,
Rusty.
next prev parent reply other threads:[~2009-11-19 23:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 15:06 [Qemu-devel] virtio: Report new guest memory statistics pertinent to memory ballooning (V4) Adam Litke
2009-11-19 15:19 ` virtio: Add memory statistics reporting to the balloon driver (V3) Adam Litke
2009-11-19 15:19 ` [Qemu-devel] " Adam Litke
2009-11-19 15:22 ` Avi Kivity
2009-11-19 15:22 ` [Qemu-devel] " Avi Kivity
2009-11-19 15:22 ` Avi Kivity
2009-11-19 15:58 ` Adam Litke
2009-11-19 15:58 ` Adam Litke
2009-11-19 15:58 ` [Qemu-devel] " Adam Litke
2009-11-19 16:13 ` Avi Kivity
2009-11-19 16:13 ` [Qemu-devel] " Avi Kivity
2009-11-19 16:29 ` Adam Litke
2009-11-19 16:29 ` [Qemu-devel] " Adam Litke
2009-11-19 16:29 ` Adam Litke
2009-11-19 16:13 ` Avi Kivity
2009-11-19 23:53 ` Rusty Russell [this message]
2009-11-19 23:53 ` [Qemu-devel] " Rusty Russell
2009-11-19 23:53 ` Rusty Russell
2009-11-23 9:44 ` Michael S. Tsirkin
2009-11-23 9:44 ` [Qemu-devel] " Michael S. Tsirkin
2009-11-23 11:00 ` Dor Laor
2009-11-23 11:00 ` Dor Laor
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:31 ` Vadim Rozenfeld
2009-11-23 11:00 ` Dor Laor
2009-11-23 9:44 ` Michael S. Tsirkin
2009-11-19 15:19 ` Adam Litke
2009-11-19 15:19 ` [Qemu-devel] Re: virtio: Report new guest memory statistics pertinent to memory ballooning (V4) Avi Kivity
2009-11-19 15:56 ` Adam Litke
2009-11-19 16:02 ` Avi Kivity
2009-11-23 18:47 ` Anthony Liguori
2009-11-20 1:24 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911201023.30709.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.