All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-next@vger.kernel.org
Subject: Re: [Next] CPU Hotplug test failures on powerpc
Date: Tue, 15 Dec 2009 16:03:22 +0100	[thread overview]
Message-ID: <1260889402.4165.434.camel@twins> (raw)
In-Reply-To: <4B279370.5050800@in.ibm.com>


Could you try the below?

---
 init/main.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/init/main.c b/init/main.c
index 4051d75..4be7de2 100644
--- a/init/main.c
+++ b/init/main.c
@@ -369,12 +369,6 @@ static void __init smp_init(void)
 {
 	unsigned int cpu;
 
-	/*
-	 * Set up the current CPU as possible to migrate to.
-	 * The other ones will be done by cpu_up/cpu_down()
-	 */
-	set_cpu_active(smp_processor_id(), true);
-
 	/* FIXME: This should be done in userspace --RR */
 	for_each_present_cpu(cpu) {
 		if (num_online_cpus() >= setup_max_cpus)
@@ -486,6 +480,7 @@ static void __init boot_cpu_init(void)
 	int cpu = smp_processor_id();
 	/* Mark the boot cpu "present", "online" etc for SMP and UP case */
 	set_cpu_online(cpu, true);
+	set_cpu_active(cpu, true);
 	set_cpu_present(cpu, true);
 	set_cpu_possible(cpu, true);
 }

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-next@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>
Subject: Re: [Next] CPU Hotplug test failures on powerpc
Date: Tue, 15 Dec 2009 16:03:22 +0100	[thread overview]
Message-ID: <1260889402.4165.434.camel@twins> (raw)
In-Reply-To: <4B279370.5050800@in.ibm.com>


Could you try the below?

---
 init/main.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/init/main.c b/init/main.c
index 4051d75..4be7de2 100644
--- a/init/main.c
+++ b/init/main.c
@@ -369,12 +369,6 @@ static void __init smp_init(void)
 {
 	unsigned int cpu;
=20
-	/*
-	 * Set up the current CPU as possible to migrate to.
-	 * The other ones will be done by cpu_up/cpu_down()
-	 */
-	set_cpu_active(smp_processor_id(), true);
-
 	/* FIXME: This should be done in userspace --RR */
 	for_each_present_cpu(cpu) {
 		if (num_online_cpus() >=3D setup_max_cpus)
@@ -486,6 +480,7 @@ static void __init boot_cpu_init(void)
 	int cpu =3D smp_processor_id();
 	/* Mark the boot cpu "present", "online" etc for SMP and UP case */
 	set_cpu_online(cpu, true);
+	set_cpu_active(cpu, true);
 	set_cpu_present(cpu, true);
 	set_cpu_possible(cpu, true);
 }

  reply	other threads:[~2009-12-15 15:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 10:53 [Next] CPU Hotplug test failures on powerpc Sachin Sant
2009-12-11 10:53 ` Sachin Sant
2009-12-14  2:48 ` Benjamin Herrenschmidt
2009-12-14  2:48   ` Benjamin Herrenschmidt
2009-12-14  4:37   ` Sachin Sant
2009-12-14  4:37     ` Sachin Sant
2009-12-14 10:22 ` Peter Zijlstra
2009-12-14 10:22   ` Peter Zijlstra
2009-12-14 11:11   ` Sachin Sant
2009-12-14 11:11     ` Sachin Sant
2009-12-14 11:11     ` Sachin Sant
2009-12-14 12:19     ` Peter Zijlstra
2009-12-14 12:19       ` Peter Zijlstra
2009-12-14 21:17       ` Benjamin Herrenschmidt
2009-12-14 21:17         ` Benjamin Herrenschmidt
2009-12-15  9:44         ` Sachin Sant
2009-12-15  9:44           ` Sachin Sant
2009-12-15 10:43           ` Peter Zijlstra
2009-12-15 10:43             ` Peter Zijlstra
2009-12-15 13:47             ` Sachin Sant
2009-12-15 13:47               ` Sachin Sant
2009-12-15 15:03               ` Peter Zijlstra [this message]
2009-12-15 15:03                 ` Peter Zijlstra
2009-12-16  5:38                 ` Sachin Sant
2009-12-16  5:38                   ` Sachin Sant
2009-12-16  7:14                   ` Peter Zijlstra
2009-12-16  7:14                     ` Peter Zijlstra
2009-12-16  6:56               ` Xiaotian Feng
2009-12-16  6:56                 ` Xiaotian Feng
2009-12-16  6:25 ` Xiaotian Feng
2009-12-16  6:25   ` Xiaotian Feng
2009-12-16  6:41   ` Sachin Sant
2009-12-16  6:41     ` Sachin Sant
2009-12-16  6:45     ` Xiaotian Feng
2009-12-16  6:45       ` Xiaotian Feng
2009-12-16  6:54       ` Sachin Sant
2009-12-16  6:54         ` Sachin Sant
2009-12-16  7:18         ` Peter Zijlstra
2009-12-16  7:18           ` Peter Zijlstra
2009-12-16  7:57           ` Xiaotian Feng
2009-12-16  7:57             ` Xiaotian Feng
2009-12-16  8:24             ` Sachin Sant
2009-12-16  8:24               ` Sachin Sant
2009-12-16  9:07               ` Xiaotian Feng
2009-12-16  9:07                 ` Xiaotian Feng
2009-12-16  9:07                 ` Xiaotian Feng
2009-12-16  9:15               ` [PATCH] fix cpu hotplug " Xiaotian Feng
2009-12-16 10:16                 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260889402.4165.434.camel@twins \
    --to=peterz@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=sachinp@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.