* [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips
@ 2010-01-02 7:34 Guo Hongruan
2010-01-02 8:35 ` Holger Hans Peter Freyther
0 siblings, 1 reply; 4+ messages in thread
From: Guo Hongruan @ 2010-01-02 7:34 UTC (permalink / raw)
To: openembedded-devel
1. Add mips entry for linux-uclibc into package_qa_get_machine_dict of insane.bbclass. Without it the insance check will fail due to key miss exception.
2. Rewrite the complete qemumips/uClibc.machine, In the previous one, the TARGET_ARCH is set i386 (not mips).
---
classes/insane.bbclass | 1 +
.../uclibc/uclibc-0.9.30.1/qemumips/uClibc.machine | 49 +++++++++-----------
2 files changed, 23 insertions(+), 27 deletions(-)
diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 495c3a5..804caf0 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -61,6 +61,7 @@ def package_qa_get_machine_dict():
"i486": ( 3, 0, 0, True, True),
"i586": ( 3, 0, 0, True, True),
"i686": ( 3, 0, 0, True, True),
+ "mips": ( 8, 0, 0, False, True),
"mipsel": ( 8, 0, 0, True, True),
"avr32": (6317, 0, 0, False, True),
"sh4": (42, 0, 0, True, True),
diff --git a/recipes/uclibc/uclibc-0.9.30.1/qemumips/uClibc.machine b/recipes/uclibc/uclibc-0.9.30.1/qemumips/uClibc.machine
index 44fec16..1cf1add 100644
--- a/recipes/uclibc/uclibc-0.9.30.1/qemumips/uClibc.machine
+++ b/recipes/uclibc/uclibc-0.9.30.1/qemumips/uClibc.machine
@@ -1,21 +1,22 @@
#
# Automatically generated make config: don't edit
-# Fri Nov 23 15:49:33 2007
+# Wed Jul 9 13:37:36 2008
#
# TARGET_alpha is not set
# TARGET_arm is not set
+# TARGET_avr32 is not set
# TARGET_bfin is not set
# TARGET_cris is not set
# TARGET_e1 is not set
# TARGET_frv is not set
# TARGET_h8300 is not set
# TARGET_hppa is not set
-TARGET_i386=y
+# TARGET_i386 is not set
# TARGET_i960 is not set
# TARGET_ia64 is not set
# TARGET_m68k is not set
# TARGET_microblaze is not set
-# TARGET_mips is not set
+TARGET_mips=y
# TARGET_nios is not set
# TARGET_nios2 is not set
# TARGET_powerpc is not set
@@ -25,44 +26,38 @@ TARGET_i386=y
# TARGET_v850 is not set
# TARGET_vax is not set
# TARGET_x86_64 is not set
+# TARGET_xtensa is not set
#
# Target Architecture Features and Options
#
-TARGET_ARCH="i386"
+TARGET_ARCH="mips"
FORCE_OPTIONS_FOR_ARCH=y
-CONFIG_GENERIC_386=y
-# CONFIG_386 is not set
-# CONFIG_486 is not set
-# CONFIG_586 is not set
-# CONFIG_586MMX is not set
-# CONFIG_686 is not set
-# CONFIG_PENTIUMII is not set
-# CONFIG_PENTIUMIII is not set
-# CONFIG_PENTIUM4 is not set
-# CONFIG_K6 is not set
-# CONFIG_K7 is not set
-# CONFIG_ELAN is not set
-# CONFIG_CRUSOE is not set
-# CONFIG_WINCHIPC6 is not set
-# CONFIG_WINCHIP2 is not set
-# CONFIG_CYRIXIII is not set
-# CONFIG_NEHEMIAH is not set
+ARCH_CFLAGS="-mno-split-addresses"
+CONFIG_MIPS_O32_ABI=y
+# CONFIG_MIPS_N32_ABI is not set
+# CONFIG_MIPS_N64_ABI is not set
+# CONFIG_MIPS_ISA_1 is not set
+# CONFIG_MIPS_ISA_2 is not set
+# CONFIG_MIPS_ISA_3 is not set
+# CONFIG_MIPS_ISA_4 is not set
+CONFIG_MIPS_ISA_MIPS32=y
+# CONFIG_MIPS_ISA_MIPS64 is not set
TARGET_SUBARCH=""
#
# Using ELF file format
#
-ARCH_LITTLE_ENDIAN=y
-
-#
-# Using Little Endian
-#
+ARCH_ANY_ENDIAN=y
+# ARCH_BIG_ENDIAN is not set
+ARCH_WANTS_BIG_ENDIAN=y
+# ARCH_WANTS_LITTLE_ENDIAN=y
ARCH_HAS_MMU=y
ARCH_USE_MMU=y
UCLIBC_HAS_FLOATS=y
UCLIBC_HAS_FPU=y
-DO_C99_MATH=y
+# DO_C99_MATH is not set
+# UCLIBC_HAS_FENV is not set
KERNEL_HEADERS="/usr/include"
HAVE_DOT_CONFIG=y
--
1.5.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips
2010-01-02 7:34 [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips Guo Hongruan
@ 2010-01-02 8:35 ` Holger Hans Peter Freyther
2010-01-02 8:42 ` Guo Hongruan
0 siblings, 1 reply; 4+ messages in thread
From: Holger Hans Peter Freyther @ 2010-01-02 8:35 UTC (permalink / raw)
To: openembedded-devel
On Saturday 02 January 2010 08:34:34 Guo Hongruan wrote:
> 1. Add mips entry for linux-uclibc into package_qa_get_machine_dict of
> insane.bbclass. Without it the insance check will fail due to key miss
> exception.
> 2. Rewrite the complete qemumips/uClibc.machine, In the
> previous one, the TARGET_ARCH is set i386 (not mips). ---
> classes/insane.bbclass | 1 +
Please split up the patch as there is no relationship between the two things.
The first one is a nice catch and I thought we already had this. I can't
comment on the second one.
The other bit is... use "Signed-off-by:" on your patches if you want them
included in OE. Only if you use the above they will show up in
patchwork.openembedded.org which people go through to look at outstanding
patches...
thanks
z.!
PS: keep up the nice work :)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips
2010-01-02 8:35 ` Holger Hans Peter Freyther
@ 2010-01-02 8:42 ` Guo Hongruan
2010-01-02 9:08 ` signed-off procedure (was: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips) Paul Menzel
0 siblings, 1 reply; 4+ messages in thread
From: Guo Hongruan @ 2010-01-02 8:42 UTC (permalink / raw)
To: openembedded-devel
Hi,
在 Sat, 02 Jan 2010 16:35:04 +0800,Holger Hans Peter Freyther
<holger+oe@freyther.de> 写道:
> On Saturday 02 January 2010 08:34:34 Guo Hongruan wrote:
>> 1. Add mips entry for linux-uclibc into package_qa_get_machine_dict of
>> insane.bbclass. Without it the insance check will fail due to key miss
>> exception.
>
>> 2. Rewrite the complete qemumips/uClibc.machine, In the
>> previous one, the TARGET_ARCH is set i386 (not mips). ---
>> classes/insane.bbclass | 1 +
>
>
> Please split up the patch as there is no relationship between the two
> things.
Sorry, I will. I found these bugs using the same test case.
> The first one is a nice catch and I thought we already had this. I can't
> comment on the second one.
The second patch is obvious. The qemumips/uClibc.machine was copied from
qemux86/uClibc.machine without any modification. It causes the building
for qemumips + uclibc failed.
>
> The other bit is... use "Signed-off-by:" on your patches if you want them
> included in OE. Only if you use the above they will show up in
> patchwork.openembedded.org which people go through to look at outstanding
> patches...
Signed-off-by? How to do it. Could you give me some links about this
topics? I will google it
>
> thanks
> z.!
>
> PS: keep up the nice work :)
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
--
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* signed-off procedure (was: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips)
2010-01-02 8:42 ` Guo Hongruan
@ 2010-01-02 9:08 ` Paul Menzel
0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2010-01-02 9:08 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
Dear Guo,
Am Samstag, den 02.01.2010, 16:42 +0800 schrieb Guo Hongruan:
> 在 Sat, 02 Jan 2010 16:35:04 +0800,Holger Hans Peter Freyther
> <holger+oe@freyther.de> 写道:
[…]
> > The other bit is... use "Signed-off-by:" on your patches if you want them
> > included in OE. Only if you use the above they will show up in
> > patchwork.openembedded.org which people go through to look at outstanding
> > patches...
>
> Signed-off-by? How to do it.
Just add a line
Signed-off-by: name <email>
below the commit message. In Git you can specify to do this
automatically most of the time with the »-s« parameter, for example when
you commit something or format a patch.
> Could you give me some links about this topics? I will google it
The coreboot project took this also over from Linux [1]. I did not find
a link to where the recent Linux procedure is described. Basically if
you sign off a patch, you will say that you are complying with the
project rules and license terms so that it can be included.
[…]
Bests,
Paul
[1] http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-02 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-02 7:34 [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips Guo Hongruan
2010-01-02 8:35 ` Holger Hans Peter Freyther
2010-01-02 8:42 ` Guo Hongruan
2010-01-02 9:08 ` signed-off procedure (was: [PATCH] Fix compiling error of uclibc-initial-0.9.30.1 due to incorrect uClibc.machine for qemumips) Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.