From: Ian Campbell <Ian.Campbell@citrix.com>
To: Keir Fraser <Keir.Fraser@eu.citrix.com>
Cc: ksrinivasan <ksrinivasan@novell.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] PV driver compatibility
Date: Thu, 21 Jan 2010 20:38:20 +0000 [thread overview]
Message-ID: <1264106300.21707.57.camel@localhost.localdomain> (raw)
In-Reply-To: <C77CDAD6.6D76%keir.fraser@eu.citrix.com>
On Wed, 2010-01-20 at 16:07 +0000, Keir Fraser wrote:
> On 20/01/2010 16:02, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:
>
> > The attached patch fixes what I believe is a typo and permits guests running
> > the latest PV drivers to correctly interact with older back-ends.
> >
> > Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
>
> Ian,
>
> You introduced the magic port value check, in xen-unstable:19964.
I'm guilty of pretty poor changelogging there, aren't I, I've no idea
how the unmodified drivers part of the change relates to the comment :-(
> Can you ack/nack this please?
What vintage of older back-ends are we talking about?
What is their behaviour when reading from that port? Can we test for a
specific value instead of anything != MAGIC or is there some other way
to identify them?
Without some sort of unplugging mechanism we run the risk of having both
PV and Emulated disk controllers active, accessing the same virtual disk
and with drivers loaded in the guest, which is potentially very
dangerous for the user's data. Did those older backends implement some
alternative unplugging mechanism we should be trying?
The whole point of this magic check is to ensure we are running on a
backend which is new enough to do the unplugging in a safe way, so I
think failing to switch to PV and sticking with emulated on such
platforms the safe approach.
I'd suggest that this issue should be fixed by backporting the backend
support for the safe unplug protocol -- I don't think the patch for such
minimal support is that big or risky. Failing that perhaps it could at
least be something you need to explicitly ask for if you have somehow
verified that there is no danger of the emulated and PV backends
trampling each other, e.g. via a frontend module parameter.
Ian.
next prev parent reply other threads:[~2010-01-21 20:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 16:02 [PATCH] PV driver compatibility Ky Srinivasan
2010-01-20 16:07 ` Keir Fraser
2010-01-21 20:38 ` Ian Campbell [this message]
2010-01-21 21:46 ` Keir Fraser
2010-01-22 7:31 ` Ian Campbell
2010-01-22 8:03 ` Keir Fraser
2010-01-22 8:43 ` Ian Campbell
2010-01-22 9:07 ` Keir Fraser
2010-01-22 10:45 ` Keir Fraser
2010-01-22 11:16 ` Pasi Kärkkäinen
2010-01-26 10:12 ` Pasi Kärkkäinen
2010-01-26 10:19 ` Keir Fraser
[not found] <4B586E2D020000300007DDE1@sinclair.provo.novell.com>
2010-01-21 23:04 ` Ky Srinivasan
2010-01-22 7:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264106300.21707.57.camel@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=ksrinivasan@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.