All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Keir Fraser <Keir.Fraser@eu.citrix.com>
Cc: ksrinivasan <ksrinivasan@novell.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] PV driver compatibility
Date: Fri, 22 Jan 2010 08:43:41 +0000	[thread overview]
Message-ID: <1264149821.21707.88.camel@localhost.localdomain> (raw)
In-Reply-To: <C77F0C45.717E%keir.fraser@eu.citrix.com>

On Fri, 2010-01-22 at 08:03 +0000, Keir Fraser wrote: 
> On 22/01/2010 07:31, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
> 
> > Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
> > and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
> > they should be used, which suggests I wasn't quite ready to send the
> > patch...
> 
> Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the
> patch?
> 
> > The protocol allows for coarse grained selection of which devices to
> > unplug:
> > 6) The drivers write a two-byte bitmask of devices to unplug to IO
> >    port 0x10.  The defined fields are:
> 
> Well, the flexibility is nice, but not a feature that driver currently
> actually uses.
> 
> My default action right now will be to add a module option to specify
> selective or complete flushing, keep the patch, but only fail to load
> drivers if flush is requested but not possible, otherwise just warn.

Sounds good, what will the default flush setting be?

Could you swap out the 0xdead and 0xbeef for the defines which are
specified right above the function in question while you are there?

Ian.

  reply	other threads:[~2010-01-22  8:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 16:02 [PATCH] PV driver compatibility Ky Srinivasan
2010-01-20 16:07 ` Keir Fraser
2010-01-21 20:38   ` Ian Campbell
2010-01-21 21:46     ` Keir Fraser
2010-01-22  7:31       ` Ian Campbell
2010-01-22  8:03         ` Keir Fraser
2010-01-22  8:43           ` Ian Campbell [this message]
2010-01-22  9:07             ` Keir Fraser
2010-01-22 10:45             ` Keir Fraser
2010-01-22 11:16               ` Pasi Kärkkäinen
2010-01-26 10:12                 ` Pasi Kärkkäinen
2010-01-26 10:19                   ` Keir Fraser
     [not found] <4B586E2D020000300007DDE1@sinclair.provo.novell.com>
2010-01-21 23:04 ` Ky Srinivasan
2010-01-22  7:37   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264149821.21707.88.camel@localhost.localdomain \
    --to=ian.campbell@citrix.com \
    --cc=Keir.Fraser@eu.citrix.com \
    --cc=ksrinivasan@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.