From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: ksrinivasan <ksrinivasan@novell.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] PV driver compatibility
Date: Thu, 21 Jan 2010 21:46:56 +0000 [thread overview]
Message-ID: <C77E7BD0.712C%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1264106300.21707.57.camel@localhost.localdomain>
On 21/01/2010 20:38, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
>> You introduced the magic port value check, in xen-unstable:19964.
>
> I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> how the unmodified drivers part of the change relates to the comment :-(
Yes, I wonder if it was even meant to be checked in. Or if it's an
accidental merge of two patches both of which you intended to go in.
I'm not sure unconditional unplug, as implemented, is a good idea. I can
imagine people with setups in which emulated devices coexist with pv
devices. Such a setup breaks if emulated devices all get unplugged when pv
drivers load. Presumably in the environment this patch came from (Citrix
XenServer) such a situation is disallowed, but I'm not so sure about
proscribing it more generally.
Some people do want unplug though, so I think making it a non-default module
option is a good idea.
-- Keir
next prev parent reply other threads:[~2010-01-21 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 16:02 [PATCH] PV driver compatibility Ky Srinivasan
2010-01-20 16:07 ` Keir Fraser
2010-01-21 20:38 ` Ian Campbell
2010-01-21 21:46 ` Keir Fraser [this message]
2010-01-22 7:31 ` Ian Campbell
2010-01-22 8:03 ` Keir Fraser
2010-01-22 8:43 ` Ian Campbell
2010-01-22 9:07 ` Keir Fraser
2010-01-22 10:45 ` Keir Fraser
2010-01-22 11:16 ` Pasi Kärkkäinen
2010-01-26 10:12 ` Pasi Kärkkäinen
2010-01-26 10:19 ` Keir Fraser
[not found] <4B586E2D020000300007DDE1@sinclair.provo.novell.com>
2010-01-21 23:04 ` Ky Srinivasan
2010-01-22 7:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C77E7BD0.712C%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=ksrinivasan@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.