* [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register
@ 2010-01-27 14:18 Michel Pollet
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
2010-01-27 14:58 ` [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Ben Dooks
0 siblings, 2 replies; 7+ messages in thread
From: Michel Pollet @ 2010-01-27 14:18 UTC (permalink / raw)
To: linux-arm-kernel
So add it's flag to the UART definition to allow
generation of more precise baud rates for the various
clock combinations.
Signed-off-by: Michel Pollet <buserror@gmail.com>
---
drivers/serial/s3c2412.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/s3c2412.c b/drivers/serial/s3c2412.c
index ce75e28..1700b1a 100644
--- a/drivers/serial/s3c2412.c
+++ b/drivers/serial/s3c2412.c
@@ -102,6 +102,7 @@ static struct s3c24xx_uart_info s3c2412_uart_inf = {
.name = "Samsung S3C2412 UART",
.type = PORT_S3C2412,
.fifosize = 64,
+ .has_divslot = 1,
.rx_fifomask = S3C2440_UFSTAT_RXMASK,
.rx_fifoshift = S3C2440_UFSTAT_RXSHIFT,
.rx_fifofull = S3C2440_UFSTAT_RXFULL,
--
1.6.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] ARM: S3C: Configuration override for UART names
2010-01-27 14:18 [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
@ 2010-01-27 14:18 ` Michel Pollet
2010-01-27 14:18 ` [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names Michel Pollet
2010-01-27 14:59 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Ben Dooks
2010-01-27 14:58 ` [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Ben Dooks
1 sibling, 2 replies; 7+ messages in thread
From: Michel Pollet @ 2010-01-27 14:18 UTC (permalink / raw)
To: linux-arm-kernel
S3C UART devices are named s3c2410_serialX and it is
inconsistent with the kernel at boot time (console=ttySACx)
This patch allows the config file to override this and
use the standard name instead.
Signed-off-by: Michel Pollet <buserror@gmail.com>
---
drivers/serial/samsung.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
index 52e3df1..e3dd135 100644
--- a/drivers/serial/samsung.c
+++ b/drivers/serial/samsung.c
@@ -55,7 +55,14 @@
/* UART name and device definitions */
+#ifdef CONFIG_S3C_STD_UART_NAMES
+/* All other SoC use this naming sheme,
+ including the kernel earlier at boot time */
#define S3C24XX_SERIAL_NAME "ttySAC"
+#else
+/* Legacy option */
+#define S3C24XX_SERIAL_NAME "s3c2410_serial"
+#endif
#define S3C24XX_SERIAL_MAJOR 204
#define S3C24XX_SERIAL_MINOR 64
@@ -878,7 +885,7 @@ static struct uart_ops s3c24xx_serial_ops = {
static struct uart_driver s3c24xx_uart_drv = {
.owner = THIS_MODULE,
- .dev_name = "s3c2410_serial",
+ .dev_name = S3C24XX_SERIAL_NAME,
.nr = CONFIG_SERIAL_SAMSUNG_UARTS,
.cons = S3C24XX_SERIAL_CONSOLE,
.driver_name = S3C24XX_SERIAL_NAME,
--
1.6.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
@ 2010-01-27 14:18 ` Michel Pollet
2010-01-27 14:59 ` Ben Dooks
2010-01-27 14:59 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Ben Dooks
1 sibling, 1 reply; 7+ messages in thread
From: Michel Pollet @ 2010-01-27 14:18 UTC (permalink / raw)
To: linux-arm-kernel
S3C UART devices are named s3c2410_serialX and it is
inconsistent with the kernel at boot time (console=ttySACx)
This patch allows the config file to override this and
use the standard name instead.
Signed-off-by: Michel Pollet <buserror@gmail.com>
---
arch/arm/plat-s3c/Kconfig | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-s3c/Kconfig b/arch/arm/plat-s3c/Kconfig
index 9e9d028..158257a 100644
--- a/arch/arm/plat-s3c/Kconfig
+++ b/arch/arm/plat-s3c/Kconfig
@@ -113,6 +113,15 @@ config S3C_LOWLEVEL_UART_PORT
this configuration should be between zero and two. The port
must have been initialised by the boot-loader before use.
+config S3C_STD_UART_NAMES
+ bool "Name S3C UART device files as ttySACx"
+ default n
+ help
+ The kernel and most other SoC use the ttySACx naming scheme
+ for UART device file naming. The default for S3C is to use
+ s3c2410_serialX, and it confuses a lot of distros; it is also
+ inconsistent with the console= kernel parameter.
+
# options for gpiolib support
config S3C_GPIO_SPACE
--
1.6.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names
2010-01-27 14:18 ` [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names Michel Pollet
@ 2010-01-27 14:59 ` Ben Dooks
0 siblings, 0 replies; 7+ messages in thread
From: Ben Dooks @ 2010-01-27 14:59 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 02:18:44PM +0000, Michel Pollet wrote:
> S3C UART devices are named s3c2410_serialX and it is
> inconsistent with the kernel at boot time (console=ttySACx)
> This patch allows the config file to override this and
> use the standard name instead.
Please merge ?#2 and #3 together.
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
> arch/arm/plat-s3c/Kconfig | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-s3c/Kconfig b/arch/arm/plat-s3c/Kconfig
> index 9e9d028..158257a 100644
> --- a/arch/arm/plat-s3c/Kconfig
> +++ b/arch/arm/plat-s3c/Kconfig
> @@ -113,6 +113,15 @@ config S3C_LOWLEVEL_UART_PORT
> this configuration should be between zero and two. The port
> must have been initialised by the boot-loader before use.
>
> +config S3C_STD_UART_NAMES
> + bool "Name S3C UART device files as ttySACx"
> + default n
> + help
> + The kernel and most other SoC use the ttySACx naming scheme
> + for UART device file naming. The default for S3C is to use
> + s3c2410_serialX, and it confuses a lot of distros; it is also
> + inconsistent with the console= kernel parameter.
> +
> # options for gpiolib support
>
> config S3C_GPIO_SPACE
> --
> 1.6.6
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: S3C: Configuration override for UART names
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
2010-01-27 14:18 ` [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names Michel Pollet
@ 2010-01-27 14:59 ` Ben Dooks
2010-01-27 15:08 ` M P
1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2010-01-27 14:59 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 02:18:43PM +0000, Michel Pollet wrote:
> S3C UART devices are named s3c2410_serialX and it is
> inconsistent with the kernel at boot time (console=ttySACx)
> This patch allows the config file to override this and
> use the standard name instead.
Is this fixing an actual problem? if so what problem?
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
> drivers/serial/samsung.c | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
> index 52e3df1..e3dd135 100644
> --- a/drivers/serial/samsung.c
> +++ b/drivers/serial/samsung.c
> @@ -55,7 +55,14 @@
>
> /* UART name and device definitions */
>
> +#ifdef CONFIG_S3C_STD_UART_NAMES
> +/* All other SoC use this naming sheme,
> + including the kernel earlier at boot time */
> #define S3C24XX_SERIAL_NAME "ttySAC"
> +#else
> +/* Legacy option */
> +#define S3C24XX_SERIAL_NAME "s3c2410_serial"
> +#endif
> #define S3C24XX_SERIAL_MAJOR 204
> #define S3C24XX_SERIAL_MINOR 64
>
> @@ -878,7 +885,7 @@ static struct uart_ops s3c24xx_serial_ops = {
>
> static struct uart_driver s3c24xx_uart_drv = {
> .owner = THIS_MODULE,
> - .dev_name = "s3c2410_serial",
> + .dev_name = S3C24XX_SERIAL_NAME,
> .nr = CONFIG_SERIAL_SAMSUNG_UARTS,
> .cons = S3C24XX_SERIAL_CONSOLE,
> .driver_name = S3C24XX_SERIAL_NAME,
> --
> 1.6.6
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/3] ARM: S3C: Configuration override for UART names
2010-01-27 14:59 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Ben Dooks
@ 2010-01-27 15:08 ` M P
0 siblings, 0 replies; 7+ messages in thread
From: M P @ 2010-01-27 15:08 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 2:59 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Wed, Jan 27, 2010 at 02:18:43PM +0000, Michel Pollet wrote:
>> S3C UART devices ?are named s3c2410_serialX and it is
>> inconsistent with the kernel at boot time (console=ttySACx)
>> This patch allows the config file to override this and
>> use the standard name instead.
>
> Is this fixing an actual problem? if so what problem?
Boot with console=ttySAC0,xxx and you never find the /dev/ttySAC0 in
/dev afterward. OpenWRT get fooled, Angstrom/OE gets fooled and so
forth. In most case you spend some entertaining time trying to figure
out why you can't get a console running even tho it appears to have
booted properly.
+ Is there something sufficiently different about the s3c2410_serial
that it needs a reminder in the filename ? Do you have another case of
an UART named "ppc_serial" or "omap_serial" ? (regardless of the fact
that in many case, it's not even running on an s3c2410 proper)
+ Why have a different name than the one used by the console= parameter ?
Michel
>> Signed-off-by: Michel Pollet <buserror@gmail.com>
>> ---
>> ?drivers/serial/samsung.c | ? ?9 ++++++++-
>> ?1 files changed, 8 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
>> index 52e3df1..e3dd135 100644
>> --- a/drivers/serial/samsung.c
>> +++ b/drivers/serial/samsung.c
>> @@ -55,7 +55,14 @@
>>
>> ?/* UART name and device definitions */
>>
>> +#ifdef CONFIG_S3C_STD_UART_NAMES
>> +/* All other SoC use this naming sheme,
>> + ? including the kernel earlier at boot time */
>> ?#define S3C24XX_SERIAL_NAME ?"ttySAC"
>> +#else
>> +/* Legacy option */
>> +#define S3C24XX_SERIAL_NAME ?"s3c2410_serial"
>> +#endif
>> ?#define S3C24XX_SERIAL_MAJOR 204
>> ?#define S3C24XX_SERIAL_MINOR 64
>>
>> @@ -878,7 +885,7 @@ static struct uart_ops s3c24xx_serial_ops = {
>>
>> ?static struct uart_driver s3c24xx_uart_drv = {
>> ? ? ? .owner ? ? ? ? ?= THIS_MODULE,
>> - ? ? .dev_name ? ? ? = "s3c2410_serial",
>> + ? ? .dev_name ? ? ? = S3C24XX_SERIAL_NAME,
>> ? ? ? .nr ? ? ? ? ? ? = CONFIG_SERIAL_SAMSUNG_UARTS,
>> ? ? ? .cons ? ? ? ? ? = S3C24XX_SERIAL_CONSOLE,
>> ? ? ? .driver_name ? ?= S3C24XX_SERIAL_NAME,
>> --
>> 1.6.6
>>
>
> --
> --
> Ben
>
> Q: ? ? ?What's a light-year?
> A: ? ? ?One-third less calories than a regular year.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register
2010-01-27 14:18 [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
@ 2010-01-27 14:58 ` Ben Dooks
1 sibling, 0 replies; 7+ messages in thread
From: Ben Dooks @ 2010-01-27 14:58 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 27, 2010 at 02:18:42PM +0000, Michel Pollet wrote:
> So add it's flag to the UART definition to allow
> generation of more precise baud rates for the various
> clock combinations.
Firstly, I'd like to see this read better by placing the subject at the
front of this description
Secondly, it would be nice to re-wrap it to closer to 77 chars/line.
> Signed-off-by: Michel Pollet <buserror@gmail.com>
> ---
> drivers/serial/s3c2412.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/serial/s3c2412.c b/drivers/serial/s3c2412.c
> index ce75e28..1700b1a 100644
> --- a/drivers/serial/s3c2412.c
> +++ b/drivers/serial/s3c2412.c
> @@ -102,6 +102,7 @@ static struct s3c24xx_uart_info s3c2412_uart_inf = {
> .name = "Samsung S3C2412 UART",
> .type = PORT_S3C2412,
> .fifosize = 64,
> + .has_divslot = 1,
> .rx_fifomask = S3C2440_UFSTAT_RXMASK,
> .rx_fifoshift = S3C2440_UFSTAT_RXSHIFT,
> .rx_fifofull = S3C2440_UFSTAT_RXFULL,
> --
> 1.6.6
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-27 15:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 14:18 [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Michel Pollet
2010-01-27 14:18 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Michel Pollet
2010-01-27 14:18 ` [PATCH 3/3] ARM: S3C: Kconfig option related to UART dev names Michel Pollet
2010-01-27 14:59 ` Ben Dooks
2010-01-27 14:59 ` [PATCH 2/3] ARM: S3C: Configuration override for UART names Ben Dooks
2010-01-27 15:08 ` M P
2010-01-27 14:58 ` [PATCH 1/3] ARM: S3C2412: SoC has the fractional baud rate register Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.