All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, paulus@samba.org,
	robert.richter@amd.com, fweisbec@gmail.com,
	Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 3/5] perf, x86: Disable PEBS on clowertown chips
Date: Fri, 05 Mar 2010 22:05:34 +0100	[thread overview]
Message-ID: <1267823134.4997.5.camel@laptop> (raw)
In-Reply-To: <1267816553.4942.6.camel@laptop>

On Fri, 2010-03-05 at 20:15 +0100, Peter Zijlstra wrote:
> On Fri, 2010-03-05 at 10:58 -0800, Stephane Eranian wrote:
> > >        case 15: /* original 65 nm celeron/pentium/core2/xeon, "Merom"/"Conroe" */
> > > +               x86_pmu.quirks = intel_clowertown_quirks;
> > 
> > That's too coarse grain!
> > It is more subtle than this. Some of the errata are marked as Plan
> > fix. They seem to be
> > fixed in later models. Your looking at the E5xxx series errata but the
> > E7xxx do not have
> > the same problems. 
> 
> OK, I'll look at those errata again and try to come up with a stepping
> test for this errata. 

The two serious ones, AJ106 and AJ68 are no fix and are listed as such
in all errata I can find, including the 7[23]00 series.

I checked the 65nm Core2Duo, Xeon 5200 and Xeon 7[23]00 spec updates.
Going by that it seems the full model 15 family is broken and I'll leave
the patch as is.




  parent reply	other threads:[~2010-03-05 21:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 15:39 [PATCH 0/5] PEBS and LBR fixes Peter Zijlstra
2010-03-05 15:39 ` [PATCH 1/5] perf: Rework the arch CPU-hotplug hooks Peter Zijlstra
2010-03-10 13:10   ` [tip:perf/urgent] perf: Rework and fix " tip-bot for Peter Zijlstra
2010-03-05 15:39 ` [PATCH 2/5] perf, x86: Fix silly bug in data store buffer allocation Peter Zijlstra
2010-03-10 13:20   ` [tip:perf/pebs] " tip-bot for Peter Zijlstra
2010-03-05 15:39 ` [PATCH 3/5] perf, x86: Disable PEBS on clowertown chips Peter Zijlstra
2010-03-05 18:58   ` Stephane Eranian
2010-03-05 19:15     ` Peter Zijlstra
2010-03-05 19:28       ` Stephane Eranian
2010-03-05 19:37         ` Peter Zijlstra
2010-03-05 21:05       ` Peter Zijlstra [this message]
2010-03-05 21:22         ` Stephane Eranian
2010-03-05 21:35           ` Peter Zijlstra
2010-03-05 21:38             ` Stephane Eranian
2010-03-05 21:43               ` Peter Zijlstra
2010-03-05 21:57                 ` Stephane Eranian
2010-03-05 22:25                   ` Peter Zijlstra
2010-03-05 22:33                     ` Stephane Eranian
2010-03-10 13:21   ` [tip:perf/pebs] perf, x86: Disable PEBS on clovertown chips tip-bot for Peter Zijlstra
2010-03-05 15:39 ` [PATCH 4/5] perf, x86: Clear the LBRs on init Peter Zijlstra
2010-03-10 13:21   ` [tip:perf/pebs] " tip-bot for Peter Zijlstra
2010-03-05 15:39 ` [PATCH 5/5] perf, x86: Robustify PEBS fixup Peter Zijlstra
2010-03-10 13:21   ` [tip:perf/pebs] " tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267823134.4997.5.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@infradead.org \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.