All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
	linux-wireless@vger.kernel.org,
	Reinette Chatre <reinette.chatre@intel.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/2] iwlwifi: implement disabling/enabling QoS
Date: Tue, 23 Mar 2010 09:35:47 -0700	[thread overview]
Message-ID: <1269362147.4263.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <43e72e891003230918g2e662957vd9bce29d36f3f334@mail.gmail.com>

On Tue, 2010-03-23 at 09:18 -0700, Luis R. Rodriguez wrote:

> >        if (changes & BSS_CHANGED_BEACON_INT) {
> >                priv->beacon_int = bss_conf->beacon_int;
> >                /* TODO: in AP mode, do something to make this take effect */
> 
> What happened without this BTW, did it not associate? What AP was it?
> Did you get to test with other drivers by chance?

The thing is that the microcode manages the powersaving, and generates
qos-nullfunc frames which were not understood by some APs.

I'll take another look at the patches asap, but right now I have to do
some planning.

johannes


  reply	other threads:[~2010-03-23 16:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 12:46 [PATCH 1/2] mac80211: add interface for disabling/enabling QoS Stanislaw Gruszka
2010-03-23 12:46 ` [PATCH 2/2] iwlwifi: implement " Stanislaw Gruszka
2010-03-23 16:18   ` Luis R. Rodriguez
2010-03-23 16:35     ` Johannes Berg [this message]
2010-03-23 16:47     ` Stanislaw Gruszka
2010-03-23 17:21   ` Johannes Berg
2010-03-24 16:44     ` Guy, Wey-Yi
2010-03-24 17:03       ` Guy, Wey-Yi
2010-03-23 17:19 ` [PATCH 1/2] mac80211: add interface for " Johannes Berg
2010-03-23 17:22   ` Johannes Berg
2010-03-24  9:37   ` Stanislaw Gruszka
2010-03-24 16:13     ` Johannes Berg
2010-03-25 10:46       ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269362147.4263.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=reinette.chatre@intel.com \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.