From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/2] mac80211: add interface for disabling/enabling QoS
Date: Wed, 24 Mar 2010 09:13:53 -0700 [thread overview]
Message-ID: <1269447233.6935.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100324093742.GB7512@dhcp-lab-161.englab.brq.redhat.com>
On Wed, 2010-03-24 at 10:37 +0100, Stanislaw Gruszka wrote:
> > Why "disabled" btw, and not enabled? Everything else is usually done in
> > a positive sense here, I'd say.
>
> To emphasize we disable QoS as conf_tx enable it implicitly.
Which I actually think should be changed in iwlwifi. No other driver
cares, and this has always been a bit of a mess there (in iwlwifi).
> In ideal case we want to change conf_tx to configure all queues
> or disable qos. But since this is exported to userspace additional
> disable_qos callback is the best implementation for me.
Yes, that would be ideal, but the second best thing, and one that we can
do, would be to decouple configuring QoS and enabling/disabling QoS
completely, not do a jumbled-up implementation like you're suggesting?
johannes
next prev parent reply other threads:[~2010-03-24 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 12:46 [PATCH 1/2] mac80211: add interface for disabling/enabling QoS Stanislaw Gruszka
2010-03-23 12:46 ` [PATCH 2/2] iwlwifi: implement " Stanislaw Gruszka
2010-03-23 16:18 ` Luis R. Rodriguez
2010-03-23 16:35 ` Johannes Berg
2010-03-23 16:47 ` Stanislaw Gruszka
2010-03-23 17:21 ` Johannes Berg
2010-03-24 16:44 ` Guy, Wey-Yi
2010-03-24 17:03 ` Guy, Wey-Yi
2010-03-23 17:19 ` [PATCH 1/2] mac80211: add interface for " Johannes Berg
2010-03-23 17:22 ` Johannes Berg
2010-03-24 9:37 ` Stanislaw Gruszka
2010-03-24 16:13 ` Johannes Berg [this message]
2010-03-25 10:46 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269447233.6935.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.