From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/2] iwlwifi: implement disabling/enabling QoS
Date: Tue, 23 Mar 2010 10:21:26 -0700 [thread overview]
Message-ID: <1269364886.9689.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1269348417-4081-2-git-send-email-sgruszka@redhat.com>
On Tue, 2010-03-23 at 13:46 +0100, Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
This really could use "more" text as to why etc.
> + if (changes & BSS_CHANGED_QOS) {
> + unsigned long flags;
> +
> + spin_lock_irqsave(&priv->lock, flags);
> + priv->qos_data.qos_active = bss_conf->qos_disabled ? 0 : 1;
> + iwl_activate_qos(priv, 1);
> + spin_unlock_irqrestore(&priv->lock, flags);
> + }
This seems alright, but we really need to revisit that since there's a
lot of odd logic in iwlwifi that makes some sense based on this now but
could probably be simplified now. I'll close with Wey-Yi, she worked on
QoS here at some point I think.
johannes
next prev parent reply other threads:[~2010-03-23 17:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 12:46 [PATCH 1/2] mac80211: add interface for disabling/enabling QoS Stanislaw Gruszka
2010-03-23 12:46 ` [PATCH 2/2] iwlwifi: implement " Stanislaw Gruszka
2010-03-23 16:18 ` Luis R. Rodriguez
2010-03-23 16:35 ` Johannes Berg
2010-03-23 16:47 ` Stanislaw Gruszka
2010-03-23 17:21 ` Johannes Berg [this message]
2010-03-24 16:44 ` Guy, Wey-Yi
2010-03-24 17:03 ` Guy, Wey-Yi
2010-03-23 17:19 ` [PATCH 1/2] mac80211: add interface for " Johannes Berg
2010-03-23 17:22 ` Johannes Berg
2010-03-24 9:37 ` Stanislaw Gruszka
2010-03-24 16:13 ` Johannes Berg
2010-03-25 10:46 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269364886.9689.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.