From: Marek Vasut <marek.vasut@gmail.com>
To: alsa-devel@alsa-project.org
Cc: Marek Vasut <marek.vasut@gmail.com>,
broonie@opensource.wolfsonmicro.com, eric.y.miao@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] WM8750: Fix SPITZ machine
Date: Mon, 5 Apr 2010 06:00:04 +0200 [thread overview]
Message-ID: <1270440005-25459-2-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1270440005-25459-1-git-send-email-marek.vasut@gmail.com>
This patch registers the WM8750 codec on a proper place on the SPITZ machine
after the WM8750 driver was converted to new API. Moreover, the incorrect code
is hereby removed from the aSoC driver.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
arch/arm/mach-pxa/spitz.c | 4 ++++
sound/soc/pxa/spitz.c | 7 -------
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 19b5109..58eb5e1 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -817,6 +817,10 @@ static struct i2c_board_info akita_i2c_board_info[] = {
.addr = 0x18,
.platform_data = &akita_ioexp,
},
+ {
+ .type = "wm8750",
+ .addr = 0x1b,
+ },
};
static void __init akita_init(void)
diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c
index c4cd2ac..d256f5f 100644
--- a/sound/soc/pxa/spitz.c
+++ b/sound/soc/pxa/spitz.c
@@ -322,17 +322,10 @@ static struct snd_soc_card snd_soc_spitz = {
.num_links = 1,
};
-/* spitz audio private data */
-static struct wm8750_setup_data spitz_wm8750_setup = {
- .i2c_bus = 0,
- .i2c_address = 0x1b,
-};
-
/* spitz audio subsystem */
static struct snd_soc_device spitz_snd_devdata = {
.card = &snd_soc_spitz,
.codec_dev = &soc_codec_dev_wm8750,
- .codec_data = &spitz_wm8750_setup,
};
static struct platform_device *spitz_snd_device;
--
1.7.0
WARNING: multiple messages have this Message-ID (diff)
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] WM8750: Fix SPITZ machine
Date: Mon, 5 Apr 2010 06:00:04 +0200 [thread overview]
Message-ID: <1270440005-25459-2-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1270440005-25459-1-git-send-email-marek.vasut@gmail.com>
This patch registers the WM8750 codec on a proper place on the SPITZ machine
after the WM8750 driver was converted to new API. Moreover, the incorrect code
is hereby removed from the aSoC driver.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
arch/arm/mach-pxa/spitz.c | 4 ++++
sound/soc/pxa/spitz.c | 7 -------
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 19b5109..58eb5e1 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -817,6 +817,10 @@ static struct i2c_board_info akita_i2c_board_info[] = {
.addr = 0x18,
.platform_data = &akita_ioexp,
},
+ {
+ .type = "wm8750",
+ .addr = 0x1b,
+ },
};
static void __init akita_init(void)
diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c
index c4cd2ac..d256f5f 100644
--- a/sound/soc/pxa/spitz.c
+++ b/sound/soc/pxa/spitz.c
@@ -322,17 +322,10 @@ static struct snd_soc_card snd_soc_spitz = {
.num_links = 1,
};
-/* spitz audio private data */
-static struct wm8750_setup_data spitz_wm8750_setup = {
- .i2c_bus = 0,
- .i2c_address = 0x1b,
-};
-
/* spitz audio subsystem */
static struct snd_soc_device spitz_snd_devdata = {
.card = &snd_soc_spitz,
.codec_dev = &soc_codec_dev_wm8750,
- .codec_data = &spitz_wm8750_setup,
};
static struct platform_device *spitz_snd_device;
--
1.7.0
next prev parent reply other threads:[~2010-04-05 4:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 4:00 [PATCH 1/3] WM8750: Convert to new API Marek Vasut
2010-04-05 4:00 ` Marek Vasut
2010-04-05 4:00 ` Marek Vasut [this message]
2010-04-05 4:00 ` [PATCH 2/3] WM8750: Fix SPITZ machine Marek Vasut
2010-04-05 4:00 ` [PATCH 3/3] Zipit Z2 WM8750 aSoC driver Marek Vasut
2010-04-05 4:00 ` Marek Vasut
2010-04-05 4:10 ` [PATCH 1/3] WM8750: Convert to new API Marek Vasut
2010-04-05 4:10 ` Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:44 ` Mark Brown
2010-04-05 13:44 ` Mark Brown
2010-04-05 4:13 ` [PATCH 2/3] WM8750: Fix SPITZ machine Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:41 ` Mark Brown
2010-04-05 13:41 ` Mark Brown
2010-04-07 20:50 ` Marek Vasut
2010-04-07 20:50 ` Marek Vasut
2010-04-08 9:40 ` Mark Brown
2010-04-08 9:40 ` Mark Brown
2010-04-08 14:51 ` [PATCH] WM8750: Convert to new API Marek Vasut
2010-04-08 14:51 ` Marek Vasut
2010-04-08 14:58 ` Mark Brown
2010-04-08 14:58 ` Mark Brown
2010-04-05 4:13 ` [PATCH 3/3] Zipit Z2 WM8750 aSoC driver Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:42 ` Mark Brown
2010-04-05 13:42 ` Mark Brown
2010-04-05 14:12 ` Liam Girdwood
2010-04-05 14:12 ` [alsa-devel] " Liam Girdwood
2010-04-09 21:48 ` Marek Vasut
2010-04-09 21:48 ` [alsa-devel] " Marek Vasut
2010-04-12 10:37 ` Mark Brown
2010-04-12 10:37 ` [alsa-devel] " Mark Brown
2010-04-12 12:34 ` Marek Vasut
2010-04-12 12:34 ` [alsa-devel] " Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270440005-25459-2-git-send-email-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.