From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: alsa-devel@alsa-project.org, eric.y.miao@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] WM8750: Convert to new API
Date: Thu, 8 Apr 2010 15:58:10 +0100 [thread overview]
Message-ID: <20100408145809.GB29288@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1270738309-4783-1-git-send-email-marek.vasut@gmail.com>
On Thu, Apr 08, 2010 at 04:51:49PM +0200, Marek Vasut wrote:
> @@ -172,6 +198,10 @@ static int __init jive_init(void)
> if (!machine_is_jive())
> return 0;
>
> + ret = wm8750_i2c_setup();
> + if (ret != 0)
> + return ret;
> +
The WM8750 on the JIVE is connected using SPI, not I2C. You'll want to
CC in the JIVE and S3C maintainer too (Ben Dooks for both). Looking at
the Jive machine file it's actually registering the SPI device in
arch/arm already so there shouldn't be any need to add any registration
code at all.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] WM8750: Convert to new API
Date: Thu, 8 Apr 2010 15:58:10 +0100 [thread overview]
Message-ID: <20100408145809.GB29288@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1270738309-4783-1-git-send-email-marek.vasut@gmail.com>
On Thu, Apr 08, 2010 at 04:51:49PM +0200, Marek Vasut wrote:
> @@ -172,6 +198,10 @@ static int __init jive_init(void)
> if (!machine_is_jive())
> return 0;
>
> + ret = wm8750_i2c_setup();
> + if (ret != 0)
> + return ret;
> +
The WM8750 on the JIVE is connected using SPI, not I2C. You'll want to
CC in the JIVE and S3C maintainer too (Ben Dooks for both). Looking at
the Jive machine file it's actually registering the SPI device in
arch/arm already so there shouldn't be any need to add any registration
code at all.
next prev parent reply other threads:[~2010-04-08 14:58 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 4:00 [PATCH 1/3] WM8750: Convert to new API Marek Vasut
2010-04-05 4:00 ` Marek Vasut
2010-04-05 4:00 ` [PATCH 2/3] WM8750: Fix SPITZ machine Marek Vasut
2010-04-05 4:00 ` Marek Vasut
2010-04-05 4:00 ` [PATCH 3/3] Zipit Z2 WM8750 aSoC driver Marek Vasut
2010-04-05 4:00 ` Marek Vasut
2010-04-05 4:10 ` [PATCH 1/3] WM8750: Convert to new API Marek Vasut
2010-04-05 4:10 ` Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:44 ` Mark Brown
2010-04-05 13:44 ` Mark Brown
2010-04-05 4:13 ` [PATCH 2/3] WM8750: Fix SPITZ machine Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:41 ` Mark Brown
2010-04-05 13:41 ` Mark Brown
2010-04-07 20:50 ` Marek Vasut
2010-04-07 20:50 ` Marek Vasut
2010-04-08 9:40 ` Mark Brown
2010-04-08 9:40 ` Mark Brown
2010-04-08 14:51 ` [PATCH] WM8750: Convert to new API Marek Vasut
2010-04-08 14:51 ` Marek Vasut
2010-04-08 14:58 ` Mark Brown [this message]
2010-04-08 14:58 ` Mark Brown
2010-04-05 4:13 ` [PATCH 3/3] Zipit Z2 WM8750 aSoC driver Marek Vasut
2010-04-05 4:13 ` Marek Vasut
2010-04-05 13:42 ` Mark Brown
2010-04-05 13:42 ` Mark Brown
2010-04-05 14:12 ` Liam Girdwood
2010-04-05 14:12 ` [alsa-devel] " Liam Girdwood
2010-04-09 21:48 ` Marek Vasut
2010-04-09 21:48 ` [alsa-devel] " Marek Vasut
2010-04-12 10:37 ` Mark Brown
2010-04-12 10:37 ` [alsa-devel] " Mark Brown
2010-04-12 12:34 ` Marek Vasut
2010-04-12 12:34 ` [alsa-devel] " Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2010-04-08 18:48 [PATCH] WM8750: Convert to new API Marek Vasut
2010-04-08 18:48 ` Marek Vasut
2010-04-09 11:50 ` Liam Girdwood
2010-04-09 12:00 ` Mark Brown
2010-04-09 12:00 ` Mark Brown
2010-04-08 14:59 Marek Vasut
2010-04-08 14:59 ` Marek Vasut
2010-04-08 15:05 ` Mark Brown
2010-03-26 14:19 Marek Vasut
2010-03-26 16:37 ` Liam Girdwood
2010-03-29 12:48 ` Mark Brown
2010-03-29 21:16 ` Marek Vasut
2010-03-30 9:40 ` Mark Brown
2010-04-04 23:45 ` Marek Vasut
2010-03-26 2:23 Marek Vasut
2010-03-26 10:08 ` Liam Girdwood
2010-03-26 10:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408145809.GB29288@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.