[PATCH] multipath_tools: add alias while printing checker_message

[PATCH] multipath_tools: add alias while printing checker_message

[Moger, Babu]

This patch adds alias while printing checker messages. 
Example of current Checker message. 

Apr 11 04:03:53 mymachine multipathd: sde: rdac checker reports path is down

Most of the time "sde" is meaningless when debugging the past failures. 

This patch add alias before the checker message..  
Example of the new message..

Apr 12 16:55:54 mymachine multipathd: mpathb: sde - rdac checker reports path is down

Signed-off-by: Babu Moger <babu.moger@lsi.com>
Reviewed-by: Vijay Chauhan <Vijay.Chauhan@lsi.com>

---
--- multipath-tools/multipathd/main.c.orig	2010-04-12 13:58:27.000000000 -0500
+++ multipath-tools/multipathd/main.c	2010-04-12 14:01:08.000000000 -0500
@@ -61,7 +61,7 @@
 #define CMDSIZE 160
 
 #define LOG_MSG(a,b) \
-	if (strlen(b)) condlog(a, "%s: %s", pp->dev, b);
+	if (strlen(b)) condlog(a, "%s: %s - %s", pp->mpp->alias, pp->dev, b);
 
 pthread_cond_t exit_cond = PTHREAD_COND_INITIALIZER;
 pthread_mutex_t exit_mutex = PTHREAD_MUTEX_INITIALIZER;

Re: [PATCH] multipath_tools: add alias while printing checker_message

[Christophe Varoqui]

You're right,
Applied

On mar., 2010-04-13 at 09:21 -0600, Moger, Babu wrote:
> This patch adds alias while printing checker messages. 
> Example of current Checker message. 
> 
> Apr 11 04:03:53 mymachine multipathd: sde: rdac checker reports path is down
> 
> Most of the time "sde" is meaningless when debugging the past failures. 
> 
> This patch add alias before the checker message..  
> Example of the new message..
> 
> Apr 12 16:55:54 mymachine multipathd: mpathb: sde - rdac checker reports path is down
> 
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> Reviewed-by: Vijay Chauhan <Vijay.Chauhan@lsi.com>
> 
> ---
> --- multipath-tools/multipathd/main.c.orig	2010-04-12 13:58:27.000000000 -0500
> +++ multipath-tools/multipathd/main.c	2010-04-12 14:01:08.000000000 -0500
> @@ -61,7 +61,7 @@
>  #define CMDSIZE 160
>  
>  #define LOG_MSG(a,b) \
> -	if (strlen(b)) condlog(a, "%s: %s", pp->dev, b);
> +	if (strlen(b)) condlog(a, "%s: %s - %s", pp->mpp->alias, pp->dev, b);
>  
>  pthread_cond_t exit_cond = PTHREAD_COND_INITIALIZER;
>  pthread_mutex_t exit_mutex = PTHREAD_MUTEX_INITIALIZER;
> 
> 
> 
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

multipath blocking a single path making multipath -ll , lvm commands go to D state

[brem belguebli]

Hello,

I'm trying to troubleshoot a problem we had on RHEL 5.x (dm-mp 0.4.7.x).

When a path of a multipath'd device is in blocked state (echo blocked
> /sys/bus/sdX/device/state), multipath -ll, lvm (vgs, ...) go to D
state rendering the whole thing unresponsive (global wait ratio hitting
100%). 

Tried to figure out if newer versions of dm-mp are affected, and tried
the same test on a fedora 12 box (dm-mp 0.4.9-6) and got the same
results.

device timeout is set to 30, queue_depth is 16, multipath configuration
set to "no_path_retry fail".

Nothing in syslog or anything that could help

Thanks