From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: peter maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, famz@redhat.com, qemu-devel@nongnu.org,
vijay kilari <vijay.kilari@gmail.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
Date: Wed, 24 Aug 2016 10:59:11 -0400 (EDT) [thread overview]
Message-ID: <1271571364.5255352.1472050751092.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <566a869d-1042-0bb7-7a4b-928efa5ea676@twiddle.net>
----- Original Message -----
> From: "Richard Henderson" <rth@twiddle.net>
> To: "Paolo Bonzini" <pbonzini@redhat.com>, qemu-devel@nongnu.org
> Cc: "peter maydell" <peter.maydell@linaro.org>, qemu-arm@nongnu.org, famz@redhat.com, "vijay kilari"
> <vijay.kilari@gmail.com>
> Sent: Wednesday, August 24, 2016 4:53:37 PM
> Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
>
> On 08/23/2016 09:38 PM, Paolo Bonzini wrote:
> >
> >
> > On 24/08/2016 06:30, no-reply@patchew.org wrote:
> >> ERROR: Use of volatile is usually wrong: see
> >> Documentation/volatile-considered-harmful.txt
> >> #44: FILE: util/cutils.c:289:
> >> + __asm volatile("vmovdqu -0x80(%1),%0\n\t"
> >
> > Other errors can be ignored, but please use __asm__ __volatile__ here or
> > just __asm__ (I don't think volatile is useful).
>
> I had to add volatile to keep the prefetch in advance of the loop.
> I suppose I could just add the prefetch to the asm block...
Probably easiest, or maybe add barrier() too.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, peter maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, famz@redhat.com,
vijay kilari <vijay.kilari@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
Date: Wed, 24 Aug 2016 10:59:11 -0400 (EDT) [thread overview]
Message-ID: <1271571364.5255352.1472050751092.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <566a869d-1042-0bb7-7a4b-928efa5ea676@twiddle.net>
----- Original Message -----
> From: "Richard Henderson" <rth@twiddle.net>
> To: "Paolo Bonzini" <pbonzini@redhat.com>, qemu-devel@nongnu.org
> Cc: "peter maydell" <peter.maydell@linaro.org>, qemu-arm@nongnu.org, famz@redhat.com, "vijay kilari"
> <vijay.kilari@gmail.com>
> Sent: Wednesday, August 24, 2016 4:53:37 PM
> Subject: Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero
>
> On 08/23/2016 09:38 PM, Paolo Bonzini wrote:
> >
> >
> > On 24/08/2016 06:30, no-reply@patchew.org wrote:
> >> ERROR: Use of volatile is usually wrong: see
> >> Documentation/volatile-considered-harmful.txt
> >> #44: FILE: util/cutils.c:289:
> >> + __asm volatile("vmovdqu -0x80(%1),%0\n\t"
> >
> > Other errors can be ignored, but please use __asm__ __volatile__ here or
> > just __asm__ (I don't think volatile is useful).
>
> I had to add volatile to keep the prefetch in advance of the loop.
> I suppose I could just add the prefetch to the asm block...
Probably easiest, or maybe add barrier() too.
Paolo
next prev parent reply other threads:[~2016-08-24 14:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 4:17 [Qemu-arm] [PATCH 0/7] Improve buffer_is_zero Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] " Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] [PATCH 1/7] cutils: Remove SPLAT macro Richard Henderson
2016-08-24 4:17 ` Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero Richard Henderson
2016-08-24 4:17 ` Richard Henderson
2016-08-24 8:37 ` [Qemu-arm] " Dr. David Alan Gilbert
2016-08-24 8:37 ` Dr. David Alan Gilbert
2016-08-24 4:17 ` [Qemu-devel] [PATCH 3/7] cutils: Rearrange buffer_is_zero acceleration Richard Henderson
2016-08-24 4:17 ` Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] [PATCH 4/7] cutils: Add generic prefetch Richard Henderson
2016-08-24 4:17 ` Richard Henderson
2016-08-24 4:17 ` [Qemu-arm] [PATCH 5/7] cutils: Rewrite x86 buffer zero checking Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] " Richard Henderson
2016-08-24 4:17 ` [Qemu-arm] [PATCH 6/7] cutils: Rewrite aarch64 " Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] " Richard Henderson
2016-08-24 4:17 ` [Qemu-arm] [PATCH 7/7] cutils: Rewrite ppc " Richard Henderson
2016-08-24 4:17 ` [Qemu-devel] " Richard Henderson
2016-08-24 4:30 ` [Qemu-arm] [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero no-reply
2016-08-24 4:30 ` no-reply
2016-08-24 4:38 ` [Qemu-arm] " Paolo Bonzini
2016-08-24 4:38 ` [Qemu-devel] " Paolo Bonzini
2016-08-24 14:53 ` [Qemu-arm] " Richard Henderson
2016-08-24 14:53 ` Richard Henderson
2016-08-24 14:59 ` Paolo Bonzini [this message]
2016-08-24 14:59 ` Paolo Bonzini
2016-08-24 8:34 ` [Qemu-arm] " Dr. David Alan Gilbert
2016-08-24 8:34 ` Dr. David Alan Gilbert
2016-08-24 10:26 ` Adam Richter
2016-08-24 10:26 ` Adam Richter
2016-08-24 10:52 ` [Qemu-arm] " Peter Maydell
2016-08-24 10:52 ` Peter Maydell
2016-08-24 11:45 ` [Qemu-arm] " Paolo Bonzini
2016-08-24 11:45 ` Paolo Bonzini
2016-08-24 12:22 ` [Qemu-arm] " Peter Maydell
2016-08-24 12:22 ` Peter Maydell
2016-08-25 6:37 ` [Qemu-arm] " Vijay Kilari
2016-08-25 6:37 ` [Qemu-devel] " Vijay Kilari
2016-08-25 8:04 ` [Qemu-arm] " Vijay Kilari
2016-08-25 8:04 ` [Qemu-devel] " Vijay Kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271571364.5255352.1472050751092.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vijay.kilari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.