All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, qemu-arm@nongnu.org, vijay.kilari@gmail.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 4/7] cutils: Add generic prefetch
Date: Tue, 23 Aug 2016 21:17:56 -0700	[thread overview]
Message-ID: <1472012279-20581-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1472012279-20581-1-git-send-email-rth@twiddle.net>

There's no real knowledge of the cacheline size,
just prefetching one loop ahead.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 util/cutils.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/util/cutils.c b/util/cutils.c
index 4d2edd6..0f1ce1d 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -173,6 +173,8 @@ NAME(const void *buf, size_t len)                               \
     do {                                                        \
         const VECTYPE *p = buf;                                 \
         VECTYPE t;                                              \
+        __builtin_prefetch(buf + SIZE);                         \
+        barrier();                                              \
         if (SIZE == sizeof(VECTYPE) * 4) {                      \
             t = (p[0] | p[1]) | (p[2] | p[3]);                  \
         } else if (SIZE == sizeof(VECTYPE) * 8) {               \
@@ -376,6 +378,9 @@ bool buffer_is_zero(const void *buf, size_t len)
         return true;
     }
 
+    /* Fetch the beginning of the buffer while we select the accelerator.  */
+    __builtin_prefetch(buf);
+
     /* Use an optimized zero check if possible.  Note that this also
        includes a check for an unrolled loop over longs, as well as
        the unsized, unaligned fallback to buffer_zero_base.  */
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: vijay.kilari@gmail.com, qemu-arm@nongnu.org, pbonzini@redhat.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 4/7] cutils: Add generic prefetch
Date: Tue, 23 Aug 2016 21:17:56 -0700	[thread overview]
Message-ID: <1472012279-20581-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1472012279-20581-1-git-send-email-rth@twiddle.net>

There's no real knowledge of the cacheline size,
just prefetching one loop ahead.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 util/cutils.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/util/cutils.c b/util/cutils.c
index 4d2edd6..0f1ce1d 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -173,6 +173,8 @@ NAME(const void *buf, size_t len)                               \
     do {                                                        \
         const VECTYPE *p = buf;                                 \
         VECTYPE t;                                              \
+        __builtin_prefetch(buf + SIZE);                         \
+        barrier();                                              \
         if (SIZE == sizeof(VECTYPE) * 4) {                      \
             t = (p[0] | p[1]) | (p[2] | p[3]);                  \
         } else if (SIZE == sizeof(VECTYPE) * 8) {               \
@@ -376,6 +378,9 @@ bool buffer_is_zero(const void *buf, size_t len)
         return true;
     }
 
+    /* Fetch the beginning of the buffer while we select the accelerator.  */
+    __builtin_prefetch(buf);
+
     /* Use an optimized zero check if possible.  Note that this also
        includes a check for an unrolled loop over longs, as well as
        the unsized, unaligned fallback to buffer_zero_base.  */
-- 
2.7.4

  parent reply	other threads:[~2016-08-24  4:21 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24  4:17 [Qemu-arm] [PATCH 0/7] Improve buffer_is_zero Richard Henderson
2016-08-24  4:17 ` [Qemu-devel] " Richard Henderson
2016-08-24  4:17 ` [Qemu-devel] [PATCH 1/7] cutils: Remove SPLAT macro Richard Henderson
2016-08-24  4:17   ` Richard Henderson
2016-08-24  4:17 ` [Qemu-devel] [PATCH 2/7] cutils: Export only buffer_is_zero Richard Henderson
2016-08-24  4:17   ` Richard Henderson
2016-08-24  8:37   ` [Qemu-arm] " Dr. David Alan Gilbert
2016-08-24  8:37     ` Dr. David Alan Gilbert
2016-08-24  4:17 ` [Qemu-devel] [PATCH 3/7] cutils: Rearrange buffer_is_zero acceleration Richard Henderson
2016-08-24  4:17   ` Richard Henderson
2016-08-24  4:17 ` Richard Henderson [this message]
2016-08-24  4:17   ` [Qemu-devel] [PATCH 4/7] cutils: Add generic prefetch Richard Henderson
2016-08-24  4:17 ` [Qemu-arm] [PATCH 5/7] cutils: Rewrite x86 buffer zero checking Richard Henderson
2016-08-24  4:17   ` [Qemu-devel] " Richard Henderson
2016-08-24  4:17 ` [Qemu-arm] [PATCH 6/7] cutils: Rewrite aarch64 " Richard Henderson
2016-08-24  4:17   ` [Qemu-devel] " Richard Henderson
2016-08-24  4:17 ` [Qemu-arm] [PATCH 7/7] cutils: Rewrite ppc " Richard Henderson
2016-08-24  4:17   ` [Qemu-devel] " Richard Henderson
2016-08-24  4:30 ` [Qemu-arm] [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero no-reply
2016-08-24  4:30   ` no-reply
2016-08-24  4:38   ` [Qemu-arm] " Paolo Bonzini
2016-08-24  4:38     ` [Qemu-devel] " Paolo Bonzini
2016-08-24 14:53     ` [Qemu-arm] " Richard Henderson
2016-08-24 14:53       ` Richard Henderson
2016-08-24 14:59       ` [Qemu-arm] " Paolo Bonzini
2016-08-24 14:59         ` Paolo Bonzini
2016-08-24  8:34 ` [Qemu-arm] " Dr. David Alan Gilbert
2016-08-24  8:34   ` Dr. David Alan Gilbert
2016-08-24 10:26   ` Adam Richter
2016-08-24 10:26     ` Adam Richter
2016-08-24 10:52     ` [Qemu-arm] " Peter Maydell
2016-08-24 10:52       ` Peter Maydell
2016-08-24 11:45       ` [Qemu-arm] " Paolo Bonzini
2016-08-24 11:45         ` Paolo Bonzini
2016-08-24 12:22         ` [Qemu-arm] " Peter Maydell
2016-08-24 12:22           ` Peter Maydell
2016-08-25  6:37 ` [Qemu-arm] " Vijay Kilari
2016-08-25  6:37   ` [Qemu-devel] " Vijay Kilari
2016-08-25  8:04   ` [Qemu-arm] " Vijay Kilari
2016-08-25  8:04     ` [Qemu-devel] " Vijay Kilari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472012279-20581-5-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vijay.kilari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.