All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168
Date: Tue, 08 Jun 2010 16:01:55 +0100	[thread overview]
Message-ID: <1276009315.3003.346.camel@odin> (raw)
In-Reply-To: <AANLkTimZjKvAAcK9xiXng7wJ0tVBJrmTIvMgyzrS7HqH@mail.gmail.com>

On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote:
> 2010/6/8 Eric Miao <eric.y.miao@gmail.com>:
> > 2010/6/8 Wan ZongShun <mcuos.com@gmail.com>:
> >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168,
> >> we have to do a little change to pxa2xx-ac97 file.
> >>
> >> All private register addresses were located in mach/include/ac97.h.
> >
> > This is not the right way to go, as suggested already. I hope the ac97
> > driver is more self-contained. i.e. having a platform device for:
> >
> >  - where the registers are mapped from
> >  - drcmr channel numbers can be encoded within dma resource
> >  - ac97 register definitions are not exposed everywhere
> >
> 
> Got it, so I should put above to platform_device and remove regs-ac97.h,
> any private bit definition should be removed to driver directory as
> driver _only_.
> 

...and could you also CC Mark on any ASoC related changes too.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

WARNING: multiple messages have this Message-ID (diff)
From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168
Date: Tue, 08 Jun 2010 16:01:55 +0100	[thread overview]
Message-ID: <1276009315.3003.346.camel@odin> (raw)
In-Reply-To: <AANLkTimZjKvAAcK9xiXng7wJ0tVBJrmTIvMgyzrS7HqH@mail.gmail.com>

On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote:
> 2010/6/8 Eric Miao <eric.y.miao@gmail.com>:
> > 2010/6/8 Wan ZongShun <mcuos.com@gmail.com>:
> >> In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168,
> >> we have to do a little change to pxa2xx-ac97 file.
> >>
> >> All private register addresses were located in mach/include/ac97.h.
> >
> > This is not the right way to go, as suggested already. I hope the ac97
> > driver is more self-contained. i.e. having a platform device for:
> >
> >  - where the registers are mapped from
> >  - drcmr channel numbers can be encoded within dma resource
> >  - ac97 register definitions are not exposed everywhere
> >
> 
> Got it, so I should put above to platform_device and remove regs-ac97.h,
> any private bit definition should be removed to driver directory as
> driver _only_.
> 

...and could you also CC Mark on any ASoC related changes too.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-06-08 15:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 10:55 [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168 Wan ZongShun
2010-06-08 10:55 ` Wan ZongShun
2010-06-08 11:23 ` Eric Miao
2010-06-08 11:23   ` Eric Miao
2010-06-08 14:49   ` Wan ZongShun
2010-06-08 14:49     ` Wan ZongShun
2010-06-08 15:01     ` Liam Girdwood [this message]
2010-06-08 15:01       ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276009315.3003.346.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mcuos.com@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.