All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Use a separate CCMP PN receive counter for management frames
Date: Fri, 11 Jun 2010 11:04:47 +0200	[thread overview]
Message-ID: <1276247087.3640.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100611024625.GB3985@jm.kir.nu>

On Thu, 2010-06-10 at 19:46 -0700, Jouni Malinen wrote:
> When management frame protection (IEEE 802.11w) is used, we must use a
> separate counter for tracking received CCMP packet number for the
> management frames. The previously used NUM_RX_DATA_QUEUESth queue was
> shared with data frames when QoS was not used and that can cause
> problems in detecting replays incorrectly for robust management frames.
> Add a new counter just for robust management frames to avoid this issue.

Hmm, could you add a comment to the change in the header file that says
right there it's used for mgmt frames?

johannes


  reply	other threads:[~2010-06-11  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11  2:46 [PATCH] mac80211: Use a separate CCMP PN receive counter for management frames Jouni Malinen
2010-06-11  9:04 ` Johannes Berg [this message]
2010-06-11 17:27 ` [PATCH v2] " Jouni Malinen
2010-06-12 17:34   ` Pavel Roskin
2010-06-12 17:47     ` Johannes Berg
2010-06-12 17:58       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276247087.3640.9.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jouni.malinen@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.