From: Pavel Roskin <proski@gnu.org>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Use a separate CCMP PN receive counter for management frames
Date: Sat, 12 Jun 2010 13:34:27 -0400 [thread overview]
Message-ID: <1276364067.2625.12.camel@ct> (raw)
In-Reply-To: <20100611172733.GA21347@jm.kir.nu>
On Fri, 2010-06-11 at 10:27 -0700, Jouni Malinen wrote:
> - for (i = 0; i < NUM_RX_DATA_QUEUES; i++) {
> + for (i = 0; i < NUM_RX_DATA_QUEUES + 1; i++) {
Perhaps we could have a define for NUM_RX_DATA_QUEUES + 1, e.g.
NUM_RX_ALL_QUEUES
> + int queue = ieee80211_is_mgmt(fc) ?
> + NUM_RX_DATA_QUEUES : rx->queue;
Again, it would be nice to add a define for readability, e.g.
#define NUM_RX_MGMT_QUEUE NUM_RX_DATA_QUEUES
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-06-12 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 2:46 [PATCH] mac80211: Use a separate CCMP PN receive counter for management frames Jouni Malinen
2010-06-11 9:04 ` Johannes Berg
2010-06-11 17:27 ` [PATCH v2] " Jouni Malinen
2010-06-12 17:34 ` Pavel Roskin [this message]
2010-06-12 17:47 ` Johannes Berg
2010-06-12 17:58 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276364067.2625.12.camel@ct \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.